fix(sqllab): tab layout truncated

[justinpark]

SUMMARY

Fixes #31858 (review)

In #31858, unnecessary space was created on all pages due to the div with added padding.

Before	After

The intention of this padding was to provide space for the alert container. To resolve this issue, I removed the div and added margin to the ErrorBoundary in the App container instead.

Additionally, the Layout.Content component caused issues with the full page height, resulting in improper rendering of the SQL Lab tab. This was fixed by adding display:flex.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before	After

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset-frontend/src/components/ErrorBoundary/index.tsx	✅
superset-frontend/packages/superset-ui-core/src/style/index.tsx	✅
superset-frontend/src/views/App.tsx	✅
superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Naming	✅
Database Operations	✅
Documentation	✅
Logging	✅
Error Handling	✅
Systems and Environment	✅
Objects and Data Structures	✅
Readability and Maintainability	✅
Asynchronous Processing	✅
Design Patterns	✅
Third-Party Libraries	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ support@korbit.ai

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[mistercrunch]

Similar fix here - #32006 - open to either option

[kgabryje]

LGTM!

[kgabryje]

I'll take the liberty and merge it since master is pretty broken right now

[mistercrunch]

Thanks for the fix @justinpark