chore: refactor Alert-related components by mistercrunch · Pull Request #31858 · apache/superset

mistercrunch · 2025-01-15T07:41:14Z

Chiseling at #31590 that has gotten big / unruly, in this PR is a refactor of Alert-related components, going vanilla AntD.

Also here. Deprecating colors.alerts since it's ambiguous/redundant with warning/error and does not exist in antd-v5

korbit-ai · 2025-01-15T07:41:18Z

Korbit doesn't automatically review large (500+ lines changed) pull requests such as this one. If you want me to review anyway, use /korbit-review.

superset-frontend/spec/helpers/theming.tsx

superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.tsx

superset-frontend/src/components/ErrorMessage/InvalidSQLErrorMessage.test.tsx

geido · 2025-01-15T16:33:01Z

From some functional testing:

A bit of an edge case but the error looks like it is not correctly padded in full page width

Is a chart failure considered a warning?

Same, for a chart in Explore. I am thinking these should probably be errors.

The positioning of the icon on the left of the text looks off.
In general, the text color of these alerts seem to stick out a bit too much. I know we want be as vanilla as possible but I'd like to hear @kasiazjc opinion too.

superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx

superset-frontend/src/components/ErrorMessage/ErrorAlert.stories.tsx

geido · 2025-01-15T16:46:07Z

superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx

-  title: ReactNode;
-  description?: string;
+import { useState } from 'react';
+import { Modal, Tooltip } from 'antd';


Why importing from antd directly? From one side this is the previous version of antd and on the other hand, I think we said to import components from our wrappers not from antd directly.

ooops. We really need a lint rule to catch this...

There is one, but it's set to warn.... I'll see about flipping it to Error

Done! #31963

superset-frontend/src/theme/index.ts

mistercrunch · 2025-01-23T04:55:18Z

Looks like a lot of the flakiness is there on master too, also couldn't repro locally, starting to think we should disable the flaky tests.

Lots of red in the last set of commits, no clear trigger as to what triggered it.

sadpandajoe · 2025-01-23T21:10:54Z

superset-frontend/cypress-base/cypress.config.ts

    projectId: 'ud5x2f',
    retries: {
-      runMode: 2,
+      runMode: 3,


Heads up that with this and the automatic retry, there is a potential of running this test 9 times which could extend run time.

Right, I know, getting a bit desperate here, seems the more I disable the more seem to fail...

Wondering if we're best having a strick no-flakiness policy and less retries (?) Suck to wait 6 or 9 times the time to get a true negative....

i wonder if any of them are dependent on other tests we have disabled, but if it's taking more time to pass, i think just go with it for now.

mistercrunch · 2025-01-23T23:04:37Z

.github/workflows/superset-e2e.yml

        with:
          path: ${{ github.workspace }}/superset-frontend/cypress-base/cypress/screenshots
-          name: cypress-artifact-${{ github.run_id }}-${{ github.job }}
+          name: cypress-artifact-${{ github.run_id }}-${{ github.job }}-${{ matrix.browser }}-${{ matrix.parallel_id }}


This prevents collisions across the matrix

eschutho

LGTM

sadpandajoe

All the cypress changes LGTM

geido

Thanks!

I got a bit confused and reckless on #31858, when I disabled many cypress tests, many of which are or may be flaky at times, but in this instance were probably triggered by some real issues in that PR. Renabling them all and will monitor PRs and master merges to re-disable the ones flaking as needed

pull-request-size bot added the size/XXL label Jan 15, 2025

github-actions bot added plugins packages labels Jan 15, 2025

dosubot bot added the alert-reports Namespace | Anything related to the Alert & Reports feature label Jan 15, 2025

github-actions bot added the preset-io label Jan 15, 2025

msyavuz mentioned this pull request Jan 15, 2025

chore(Network Errors): Update network errors on filter bars and charts #31811

Merged

9 tasks

geido reviewed Jan 15, 2025

View reviewed changes

superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx Show resolved Hide resolved

geido reviewed Jan 15, 2025

View reviewed changes

superset-frontend/src/components/ErrorMessage/ErrorAlert.stories.tsx Show resolved Hide resolved

geido reviewed Jan 15, 2025

View reviewed changes

justinpark self-requested a review January 15, 2025 18:25

mistercrunch commented Jan 15, 2025

View reviewed changes

superset-frontend/src/theme/index.ts Show resolved Hide resolved

github-actions bot added the doc Namespace | Anything related to documentation label Jan 16, 2025

mistercrunch force-pushed the alerts_refactor branch from 2b87057 to 2eb9330 Compare January 16, 2025 01:49

github-actions bot removed the doc Namespace | Anything related to documentation label Jan 16, 2025

mistercrunch force-pushed the alerts_refactor branch 3 times, most recently from c5c85ea to b96705d Compare January 18, 2025 00:26

mistercrunch requested review from betodealmeida, craig-rueda, dpgaspar, eschutho, kgabryje, nytai, rusackas, sadpandajoe and villebro as code owners January 18, 2025 18:42

github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jan 19, 2025

mistercrunch added 2 commits January 22, 2025 14:41

passing the rest properly

cab96a1

addressing comments

0643d1f

mistercrunch force-pushed the alerts_refactor branch from 37768e7 to 0643d1f Compare January 22, 2025 22:44

mistercrunch added 4 commits January 22, 2025 14:46

minor lint

7176848

remove closeIcon

69f7763

wait for tabstateview

c493c9e

prevent collisions on uploading artifacts

309b1cd

github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jan 22, 2025

skip 2 flaky tests

0fcbe80

mistercrunch added 3 commits January 23, 2025 09:50

one extra retries

4cc535b

more skips

b13375f

skip cypress Annotations

ea0728a

sadpandajoe reviewed Jan 23, 2025

View reviewed changes

mistercrunch added 2 commits January 23, 2025 13:18

more skippage

8ec7ec8

normal weight

8d6e9a6

mistercrunch commented Jan 23, 2025

View reviewed changes

eschutho approved these changes Jan 24, 2025

View reviewed changes

sadpandajoe approved these changes Jan 24, 2025

View reviewed changes

geido approved these changes Jan 24, 2025

View reviewed changes

mistercrunch merged commit 6eb87e0 into master Jan 24, 2025
48 checks passed

mistercrunch deleted the alerts_refactor branch January 24, 2025 16:39

justinpark mentioned this pull request Jan 28, 2025

fix(sqllab): tab layout truncated #32005

Merged

9 tasks

mistercrunch mentioned this pull request Jan 28, 2025

fix: re-enable cypress checks #32008

Merged

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025

Conversation

mistercrunch commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

korbit-ai bot commented Jan 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

geido commented Jan 15, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mistercrunch commented Jan 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eschutho left a comment

Choose a reason for hiding this comment

Uh oh!

sadpandajoe left a comment

Choose a reason for hiding this comment

Uh oh!

geido left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mistercrunch commented Jan 15, 2025 •

edited

Loading