fix: re-enable cypress checks

[mistercrunch]

I got a bit confused and reckless on #31858 while dealing with a sizable merge conflict, proceeded to disable many cypress tests, many of which are or may be flaky at times, but in this instance were probably triggered by some real issues in that PR.

Renabling them all and will monitor PRs and master merges to re-disable the ones flaking as needed.

Note that prior to the PR issues I created on #31858, there were all sorts of cypress issues that we couldn't pinpoint to any particular merges, and that led a few of us to make to call to "disable all flaking tests" with the intent to fix or replace with unit tests:

Seems there are other new issues with the way we goup/report tests as well. Still needs weeding.

[korbit-ai]

I've completed my review and didn't find any issues.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Naming	✅
Database Operations	✅
Documentation	✅
Logging	✅
Error Handling	✅
Systems and Environment	✅
Objects and Data Structures	✅
Readability and Maintainability	✅
Asynchronous Processing	✅
Design Patterns	✅
Third-Party Libraries	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ support@korbit.ai

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[sadpandajoe]

LGTM

[michael-s-molina]

@mistercrunch This seems to have broken CI. Should we revert?

[mistercrunch]

Oh yes, this is due to checks being different on master and PRs, I was trying to address (amongst other things) a master-specific bug on retries, but flying blind. Let's revert for now.

I little while back we decided to only use the Cypress dashboard feature on master and on-demand, but there's a bug that's specific to retries on that side of the logic. I vote for having the same process on master and PRs, and keep the Cypress dashboard feature on-demand (workflow_dispatch) only.

All this started when we unknowingly accumulated significant costs related to our high usage last year, and decided to try and shut down the bulk of the load.

[mistercrunch]

Revert is here -> #32045