Skip to content

feat: Oauth2 in DatabaseSelector#30082

Merged
betodealmeida merged 1 commit intomasterfrom
show-oauth2-errors
Sep 4, 2024
Merged

feat: Oauth2 in DatabaseSelector#30082
betodealmeida merged 1 commit intomasterfrom
show-oauth2-errors

Conversation

@betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Aug 31, 2024 •
edited
Loading

SUMMARY

This PR modifies onError in the useSchemas and useCatalogs hooks so that the error payload is passed as a parameter. This allow us to prompt the user for OAuth2 when adding datasets or browsing tables in SQL Lab.

Depends on #30071 and #30067.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

Screenshot 2024-08-31 at 19-21-36 Superset

Screenshot 2024-08-31 at 19-21-30 Superset

Before, generic error messages would flash.

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida marked this pull request as ready for review August 31, 2024 23:22
@dosubot dosubot bot added api Related to the REST API authentication Related to authentication labels Aug 31, 2024
@github-actions github-actions bot removed the api Related to the REST API label Aug 31, 2024
@betodealmeida betodealmeida mentioned this pull request Sep 2, 2024
Merged
9 tasks
justinpark
justinpark approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadpandajoe sadpandajoe requested a review from rtexelm September 3, 2024 18:52
rtexelm
rtexelm approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@rtexelm rtexelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betodealmeida betodealmeida changed the base branch from create-oauth2-db to master September 3, 2024 23:22
@pull-request-size pull-request-size bot added size/XL and removed size/M labels Sep 3, 2024
@pull-request-size pull-request-size bot added size/M and removed size/XL labels Sep 3, 2024
@betodealmeida betodealmeida merged commit 09dfe2f into master Sep 4, 2024
@rusackas rusackas deleted the show-oauth2-errors branch September 27, 2024 20:55
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
@betodealmeida @nyohasstium
feat: Oauth2 in DatabaseSelector (apache#30082)
53eec4a
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
@dosubot dosubot bot mentioned this pull request Sep 5, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinpark justinpark justinpark approved these changes

@rtexelm rtexelm rtexelm approved these changes

Assignees

No one assigned

Labels

authentication Related to authentication 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@betodealmeida @justinpark @rtexelm @mistercrunch