feat: allow create/update OAuth2 DB#30071
Merged
betodealmeida merged 1 commit intomasterfrom Sep 3, 2024
Merged
Conversation
c436ac9 to
33ba31c
Compare
1cd7d5e to
a95347a
Compare
9 tasks
a95347a to
d5bf844
Compare
9 tasks
nyohasstium
pushed a commit
to Webgains/superset
that referenced
this pull request
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is part of the work to add OAuth2 support for Snowflake. When creating the DB we provide only the OAuth2 client information (ID, secret, scope, auth/token URLs), which is not enough to test and validate the connection. We need to allow the DB to be created before the OAuth2 flow, so we can store the access tokens associated with a given DB.
Depends on #30067.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Added unit tests.
ADDITIONAL INFORMATION