Skip to content

feat: allow create/update OAuth2 DB#30071

Merged
betodealmeida merged 1 commit intomasterfrom
create-oauth2-db
Sep 3, 2024
Merged

feat: allow create/update OAuth2 DB#30071
betodealmeida merged 1 commit intomasterfrom
create-oauth2-db

Conversation

@betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Aug 30, 2024

SUMMARY

This PR is part of the work to add OAuth2 support for Snowflake. When creating the DB we provide only the OAuth2 client information (ID, secret, scope, auth/token URLs), which is not enough to test and validate the connection. We need to allow the DB to be created before the OAuth2 flow, so we can store the access tokens associated with a given DB.

Depends on #30067.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Added unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the api Related to the REST API label Aug 30, 2024
@betodealmeida betodealmeida force-pushed the create-oauth2-db branch 2 times, most recently from c436ac9 to 33ba31c Compare August 31, 2024 14:45
@betodealmeida betodealmeida marked this pull request as ready for review August 31, 2024 14:46
@dosubot dosubot bot added authentication Related to authentication data:connect Namespace | Anything related to db connections / integrations data:connect:snowflake Related to Snowflake labels Aug 31, 2024
@betodealmeida betodealmeida force-pushed the create-oauth2-db branch 2 times, most recently from 1cd7d5e to a95347a Compare August 31, 2024 15:05
@sadpandajoe sadpandajoe requested a review from rtexelm September 3, 2024 18:51
Copy link
Member

@rtexelm rtexelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betodealmeida betodealmeida changed the base branch from transaction-allowed-exceptions to master September 3, 2024 22:49
@betodealmeida betodealmeida merged commit 0415ed3 into master Sep 3, 2024
@rusackas rusackas deleted the create-oauth2-db branch September 4, 2024 19:55
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Related to the REST API authentication Related to authentication 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels data:connect:snowflake Related to Snowflake data:connect Namespace | Anything related to db connections / integrations preset-io size/XL 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants