Merged
Conversation
betodealmeida
commented
Sep 2, 2024
| validationErrors, | ||
| db, | ||
| }: FieldPropTypes) => { | ||
| console.error(db); |
345d079 to
fbeeb5a
Compare
1cff541 to
cea5d85
Compare
Member
|
/testenv up |
Contributor
|
@sadpandajoe Ephemeral environment spinning up at http://34.222.11.9:8080. Credentials are |
rtexelm
approved these changes
Sep 3, 2024
Member
Author
There was a problem hiding this comment.
Yeah, I was surprised it didn't exist yet!
5885a39 to
5fd7e21
Compare
cea5d85 to
46a42e1
Compare
46a42e1 to
0ac5b62
Compare
Contributor
|
Ephemeral environment shutdown and build artifacts deleted. |
9 tasks
nyohasstium
pushed a commit
to Webgains/superset
that referenced
this pull request
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
More work on Snowflake OAuth2 (this PR depends on #30082). This PR introduces a new field for the database configuration modal, allowing OAuth2 client information to be provided by the user:
The component combines the 5 different input fields, and then passes them inside the
masked_encrypted_extraattribute on database CRUD:{ "oauth2_client_info": { "id": "123456", "secret": "XXXXXXXXXXXX", "authorization_request_uri": "https://account.snowflakecomputing.com/oauth/authorize", "token_request_uri": "https://account.snowflakecomputing.com/oauth/token-request", "scope": "refresh_token session:role:USERADMIN" } }(Note that ideally we would pass these in the
parametersfield, and let the DB engine spec build the object inencrypted_extra. But thebuild_sqlalchemy_urimethod — as the name suggests — only builds an URI, so we would have to modify it to return a tuple with(uri, connect_args)if we passed them client information insideparameters, and also figure out a way to inform that these fields should be stored inencrypted_extra, notextra, so for now the frontend does the work. I left a small TODO for me to fix this in the future.)BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See above.
TESTING INSTRUCTIONS
Adding tests.
ADDITIONAL INFORMATION