fix: missing select menu background #12759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Codecov Report
@@ Coverage Diff @@
## master #12759 +/- ##
==========================================
- Coverage 66.89% 66.38% -0.51%
==========================================
Files 1021 1021
Lines 50015 50013 -2
Branches 4907 4907
==========================================
- Hits 33456 33202 -254
- Misses 16434 16682 +248
- Partials 125 129 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
reviewed
Jan 26, 2021
Member
junlincc
left a comment
junlincc
left a comment
There was a problem hiding this comment.
LGTM. i honestly don't know how that two PRs introduce this regression, almost uncatchable. just learning one bug at a time. thanks for the fix
mistercrunch
approved these changes
Jan 26, 2021
villebro
pushed a commit
that referenced
this pull request
Jan 26, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Jan 26, 2021
* master: (52 commits) docs: Updates to Superset Site for 1.0 (apache#12626) test(native-filters): scoping tree in native filters modal (apache#12655) Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219) Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224) Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227) feat(native-filters): apply scoping of native filters to dashboard (apache#12716) Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223) Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245) fix: missing select menu background (apache#12759) fix(explore): incorrect missing datasource condition (apache#12758) feat: default timepicker to last week when dataset is changed (apache#12609) feat(explore): allow opening charts with missing dataset (apache#12705) chore: upgrade Cypress to 6.2.1 (apache#12605) refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218) feat: Adding option to set_database_uri CLI command (apache#12740) docs: Fixed typo on line 348 (apache#12739) Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214) docs: Remove gatsby-plugin-offline (apache#12693) test: oracle engine spec (apache#12615) test: hive db engine spec (apache#12520) ...
mistercrunch
added
🍒 1.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add back the missing select menu background . Regression introduced by #12649 and #12699
Closes #12746
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
scroll-missing-bg.mp4
After
scroll-has-bg.mp4
The hover background not extending to full-width is harder to fix. Let's save it for next time.
TEST PLAN
Manual verification.
ADDITIONAL INFORMATION