fix: remove whitespace at the bottom of select dropdown #12699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM! i learned one more case that how a simple css change in Explore could introduce visual regressions like this. will add to test cases. thanks mud! nice padding at the bottom of control panel ✅ no extra space between dropdown and other fields ✅ |
villebro
pushed a commit
that referenced
this pull request
Jan 25, 2021
6 tasks
mistercrunch
added
🍒 1.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#12649 added an unnecessary whitespace at the bottom of the select dropdown. Let's remove it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TEST PLAN
Go check the dropdowns in the Time section
ADDITIONAL INFORMATION