docs: Updates to Superset Site for 1.0 #12626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinify
changed the title
Codecov Report
@@ Coverage Diff @@
## master #12626 +/- ##
==========================================
- Coverage 66.80% 63.61% -3.20%
==========================================
Files 1017 486 -531
Lines 49730 29984 -19746
Branches 4864 0 -4864
==========================================
- Hits 33221 19073 -14148
+ Misses 16386 10911 -5475
+ Partials 123 0 -123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amitmiran137
approved these changes
Jan 20, 2021
Member
amitmiran137
left a comment
amitmiran137
left a comment
There was a problem hiding this comment.
I think you should undo the package-lock.json file changes
no reason you should push this right?
eschutho
reviewed
Jan 20, 2021
docs/src/pages/docs/introduction.mdx
Outdated
| - Download the latest Superset version from [Pypi here](https://pypi.org/project/apache-superset/) | ||
| - Setup Superset locally with one command | ||
| using [Docker Compose](docs/installation/installing-superset-using-docker-compose) | ||
| - Download the [Docker image](https://hub.docker.com/r/apache/incubator-superset) from Dockerhub |
Member
There was a problem hiding this comment.
do we want to point to https://hub.docker.com/r/apache/superset now?
Contributor
Author
There was a problem hiding this comment.
good catch, fixing now!
lilykuang
reviewed
Jan 21, 2021
Member
lilykuang
left a comment
lilykuang
left a comment
There was a problem hiding this comment.
looks like package.json wasn't changed. can you undo the change for package-lock.json?
nytai
approved these changes
Jan 21, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Jan 26, 2021
* master: (52 commits) docs: Updates to Superset Site for 1.0 (apache#12626) test(native-filters): scoping tree in native filters modal (apache#12655) Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219) Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224) Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227) feat(native-filters): apply scoping of native filters to dashboard (apache#12716) Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223) Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245) fix: missing select menu background (apache#12759) fix(explore): incorrect missing datasource condition (apache#12758) feat: default timepicker to last week when dataset is changed (apache#12609) feat(explore): allow opening charts with missing dataset (apache#12705) chore: upgrade Cypress to 6.2.1 (apache#12605) refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218) feat: Adding option to set_database_uri CLI command (apache#12740) docs: Fixed typo on line 348 (apache#12739) Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214) docs: Remove gatsby-plugin-offline (apache#12693) test: oracle engine spec (apache#12615) test: hive db engine spec (apache#12520) ...
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Updated all screenshots to now showcase Superset 1.0 design.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN