[SPARK-52510][Geo][CONNECT][FOLLOWUP] Reserve expression proto numbers for Geometry and Geography #52746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uros-db
changed the title
uros-db
changed the title
Contributor
Author
|
@hvanhovell @cloud-fan @milastdbx Please review. |
uros-db
commented
Oct 27, 2025
Contributor
Author
uros-db
left a comment
uros-db
left a comment
There was a problem hiding this comment.
also cc @mkaravel @szehon-ho
cloud-fan
approved these changes
Oct 28, 2025
Contributor
|
thanks, merging to master! |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…s for Geometry and Geography ### What changes were proposed in this pull request? This PR follows up on apache#51204, evolving `expressions.proto` to also reserve two numbers in Spark Connect for geospatial types (`Geometry` and `Geography`). ### Why are the changes needed? Geospatial types need to have their proto file representation in expressions as well, and we need to reserve it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Regenerated Python bindings are verified via the appropriate PySpark Connect unit & integration tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52746 from uros-db/geo-exprs-proto. Authored-by: Uros Bojanic <uros.bojanic@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Dec 23, 2025
…ift` source code ### What changes were proposed in this pull request? This PR aims to update Spark Connect-generated Swift source code with Apache Spark `4.1.0`. ### Why are the changes needed? To use the latest bug fixes and new messages to develop for new features of `4.1.0`. - apache/spark#53024 - apache/spark#52894 - apache/spark#52890 - apache/spark#52872 - apache/spark#52746 - apache/spark#52831 ``` $ git clone -b v4.1.0 https://github.com/apache/spark.git $ cd spark/sql/connect/common/src/main/protobuf/ $ protoc --swift_out=. spark/connect/*.proto $ protoc --grpc-swift_out=. spark/connect/*.proto // Remove empty GRPC files $ cd spark/connect $ grep 'This file contained no services' * | awk -F: '{print $1}' | xargs rm ``` ### Does this PR introduce _any_ user-facing change? Pass the CIs. ### How was this patch tested? Pass the CIs. I manually tested with `Apache Spark 4.1.0`. ``` $ swift test --no-parallel ... Test run with 203 tests in 21 suites passed after 33.163 seconds. ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #271 from dongjoon-hyun/SPARK-54811. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR follows up on #51204, evolving
expressions.prototo also reserve two numbers in Spark Connect for geospatial types (GeometryandGeography).Why are the changes needed?
Geospatial types need to have their proto file representation in expressions as well, and we need to reserve it.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Regenerated Python bindings are verified via the appropriate PySpark Connect unit & integration tests.
Was this patch authored or co-authored using generative AI tooling?
No.