[SPARK-52510] Reserve proto numbers for Geospatial types #51204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milastdbx
changed the title
hvanhovell
approved these changes
Jun 17, 2025
Contributor
|
Merging to master. Thanks! |
cloud-fan
pushed a commit
that referenced
this pull request
Oct 28, 2025
…s for Geometry and Geography ### What changes were proposed in this pull request? This PR follows up on #51204, evolving `expressions.proto` to also reserve two numbers in Spark Connect for geospatial types (`Geometry` and `Geography`). ### Why are the changes needed? Geospatial types need to have their proto file representation in expressions as well, and we need to reserve it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Regenerated Python bindings are verified via the appropriate PySpark Connect unit & integration tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52746 from uros-db/geo-exprs-proto. Authored-by: Uros Bojanic <uros.bojanic@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…s for Geometry and Geography ### What changes were proposed in this pull request? This PR follows up on apache#51204, evolving `expressions.proto` to also reserve two numbers in Spark Connect for geospatial types (`Geometry` and `Geography`). ### Why are the changes needed? Geospatial types need to have their proto file representation in expressions as well, and we need to reserve it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Regenerated Python bindings are verified via the appropriate PySpark Connect unit & integration tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52746 from uros-db/geo-exprs-proto. Authored-by: Uros Bojanic <uros.bojanic@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR i propose we reserve numbers in spark connect proto for geospatial types, as per SPIP vote has passed these changes are coming soon and we don't want to clash with other efforts.
Why are the changes needed?
Geo types need to have their proto file representation, and we need to reserve it
Does this PR introduce any user-facing change?
No
How was this patch tested?
This is proto only change
Was this patch authored or co-authored using generative AI tooling?
No