[SPARK-54191][SDP] Add once to Defineflow Proto #52890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaqiWang18
commented
Nov 5, 2025
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto
Outdated
Show resolved
Hide resolved
Contributor
Author
JiaqiWang18
changed the title
sryza
reviewed
Nov 5, 2025
Contributor
sryza
left a comment
sryza
left a comment
There was a problem hiding this comment.
We should error until the implementation comes so that this doesn't get silently ignored.
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto
Outdated
Show resolved
Hide resolved
This reverts commit 707fc814a43f191598d33c86e5d0cf3dd294e20d.
This reverts commit d126dcc896a0b0fe1c4b6aec93c245b285f867e6.
JiaqiWang18
force-pushed
the
SPARK-54191-StandaloneFlowDetails-proto
branch
from
1cd2388 to
47dce38
Compare
sryza
approved these changes
Nov 7, 2025
Contributor
sryza
left a comment
sryza
left a comment
There was a problem hiding this comment.
LGTM! I'm kicking off the tests because it looks like they failed for an unrelated reason
Contributor
|
Thanks! Merging to master & 4.1 |
sryza
pushed a commit
that referenced
this pull request
Nov 8, 2025
### What changes were proposed in this pull request? Add `once` to Defineflow Proto, to allow creating one-time back-fill flow ### Why are the changes needed? Allow new API argument for SDP flow. ### Does this PR introduce _any_ user-facing change? No, no API change yet ### How was this patch tested? Proto changes Closes #52890 from JiaqiWang18/SPARK-54191-StandaloneFlowDetails-proto. Authored-by: Jacky Wang <[email protected]> Signed-off-by: Sandy Ryza <[email protected]> (cherry picked from commit 1a724ba) Signed-off-by: Sandy Ryza <[email protected]>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
### What changes were proposed in this pull request? Add `once` to Defineflow Proto, to allow creating one-time back-fill flow ### Why are the changes needed? Allow new API argument for SDP flow. ### Does this PR introduce _any_ user-facing change? No, no API change yet ### How was this patch tested? Proto changes Closes apache#52890 from JiaqiWang18/SPARK-54191-StandaloneFlowDetails-proto. Authored-by: Jacky Wang <[email protected]> Signed-off-by: Sandy Ryza <[email protected]>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? Add `once` to Defineflow Proto, to allow creating one-time back-fill flow ### Why are the changes needed? Allow new API argument for SDP flow. ### Does this PR introduce _any_ user-facing change? No, no API change yet ### How was this patch tested? Proto changes Closes apache#52890 from JiaqiWang18/SPARK-54191-StandaloneFlowDetails-proto. Authored-by: Jacky Wang <[email protected]> Signed-off-by: Sandy Ryza <[email protected]>
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Dec 23, 2025
…ift` source code ### What changes were proposed in this pull request? This PR aims to update Spark Connect-generated Swift source code with Apache Spark `4.1.0`. ### Why are the changes needed? To use the latest bug fixes and new messages to develop for new features of `4.1.0`. - apache/spark#53024 - apache/spark#52894 - apache/spark#52890 - apache/spark#52872 - apache/spark#52746 - apache/spark#52831 ``` $ git clone -b v4.1.0 https://github.com/apache/spark.git $ cd spark/sql/connect/common/src/main/protobuf/ $ protoc --swift_out=. spark/connect/*.proto $ protoc --grpc-swift_out=. spark/connect/*.proto // Remove empty GRPC files $ cd spark/connect $ grep 'This file contained no services' * | awk -F: '{print $1}' | xargs rm ``` ### Does this PR introduce _any_ user-facing change? Pass the CIs. ### How was this patch tested? Pass the CIs. I manually tested with `Apache Spark 4.1.0`. ``` $ swift test --no-parallel ... Test run with 203 tests in 21 suites passed after 33.163 seconds. ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #271 from dongjoon-hyun/SPARK-54811. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
onceto Defineflow Proto, to allow creating one-time back-fill flowWhy are the changes needed?
Allow new API argument for SDP flow.
Does this PR introduce any user-facing change?
No, no API change yet
How was this patch tested?
Proto changes