[SPARK-47038][BUILD] Remove shaded protobuf-java 2.6.1 dependency from kinesis-asl-assembly
#45096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom `kinesis-asl-assembly`
Contributor
|
Do we run test on Kinesis? |
Member
Author
Member
Author
|
All tests passed. |
Member
Author
|
Could you review this, please, @viirya ? |
Member
|
Looking into this. |
viirya
reviewed
Feb 14, 2024
Comment on lines
-62
to
-71
| <dependency> | ||
| <groupId>com.google.protobuf</groupId> | ||
| <artifactId>protobuf-java</artifactId> | ||
| <version>2.6.1</version> | ||
| <!-- | ||
| We are being explicit about version here and overriding the | ||
| spark default of 2.5.0 because KCL appears to have introduced | ||
| a dependency on protobuf 2.6.1 somewhere between KCL 1.4.0 and 1.6.1. | ||
| --> | ||
| </dependency> |
Member
There was a problem hiding this comment.
Before SPARK-14421, it is a provided dependency. Don't we need to keep it?
Member
Author
There was a problem hiding this comment.
Yes, it's provided dependency still as I described in the PR description.
Member
There was a problem hiding this comment.
Oh, I see. It was overriding the protobuf version.
viirya
approved these changes
Feb 14, 2024
Member
Author
|
Thank you so much, @viirya ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove the shaded
protobuf-java2.6.1 dependency fromkinesis-asl-assembly.Why are the changes needed?
Technically, this is a revert of SPARK-14421.
protobuf-java-2.5.0.jar.protobuf-java-2.5.0.jarfrom Apache Spark 3.5+ distribution.Does this PR introduce any user-facing change?
No, but the user can inject the required protobuf-jar from application layers.
How was this patch tested?
Pass the CIs and manual review.
BEFORE
AFTER
Was this patch authored or co-authored using generative AI tooling?
No.