Skip to content

[SPARK-47038][BUILD] Remove shaded protobuf-java 2.6.1 dependency from kinesis-asl-assembly #45096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-47038][BUILD] Remove shaded protobuf-java 2.6.1 dependency from kinesis-asl-assembly #45096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions connector/kinesis-asl-assembly/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,6 @@
<artifactId>commons-lang</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>2.6.1</version>
<!--
We are being explicit about version here and overriding the
spark default of 2.5.0 because KCL appears to have introduced
a dependency on protobuf 2.6.1 somewhere between KCL 1.4.0 and 1.6.1.
-->
</dependency>
Comment on lines -62 to -71
Copy link
Member

@viirya viirya Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before SPARK-14421, it is a provided dependency. Don't we need to keep it?

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Feb 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's provided dependency still as I described in the PR description.
Screenshot 2024-02-14 at 09 58 01

Copy link
Member

@viirya viirya Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. It was overriding the protobuf version.

<dependency>
<groupId>org.glassfish.jersey.core</groupId>
<artifactId>jersey-client</artifactId>
Expand Down Expand Up @@ -173,15 +163,6 @@
<include>*:*</include>
</includes>
</artifactSet>
<relocations>
<relocation>
<pattern>com.google.protobuf</pattern>
<shadedPattern>kinesis.protobuf</shadedPattern>
<includes>
<include>com.google.protobuf.**</include>
</includes>
</relocation>
</relocations>
<filters>
<filter>
<artifact>*:*</artifact>
Expand Down