[SPARK-14421] : Upgrades protobuf dependency to 2.6.1 for the new version of KCL, and… #13054
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… relocates that dependency as not to conflict with Spark's use of 2.5.0. See: SPARK-14421
boneill42
changed the title
Contributor
|
ok to test |
|
Test build #58389 has finished for PR 13054 at commit
|
Member
|
Jenkins retest this please |
|
Test build #58477 has finished for PR 13054 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 12, 2016
…on of KCL, and… ## What changes were proposed in this pull request? When running with Kinesis Consumer Library (KCL), against a stream that contains aggregated data, the KCL needs access to protobuf to de-aggregate the records. Without this patch, that results in the following error message: ``` Caused by: java.lang.ClassNotFoundException: com.google.protobuf.ProtocolStringList ``` This PR upgrades the protobuf dependency within the kinesis-asl-assembly, and relocates that package (as not to conflict with Spark's use of 2.5.0), which fixes the above CNFE. ## How was this patch tested? Used kinesis word count example against a stream containing aggregated data. See: SPARK-14421 Author: Brian O'Neill <[email protected]> Closes #13054 from boneill42/protobuf-relocation-for-kcl. (cherry picked from commit 81e3bfc) Signed-off-by: Sean Owen <[email protected]>
Member
|
Merged to master/2.0 |
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 14, 2024
…rom `kinesis-asl-assembly` ### What changes were proposed in this pull request? This PR aims to remove the shaded `protobuf-java` 2.6.1 dependency from `kinesis-asl-assembly`. ### Why are the changes needed? Technically, this is a revert of SPARK-14421. - At that time, Apache Spark 2.0.0 distribution contains `protobuf-java-2.5.0.jar`. - #13054 - SPARK-43489 removed `protobuf-java-2.5.0.jar` from Apache Spark 3.5+ distribution. - #41153 ### Does this PR introduce _any_ user-facing change? No, but the user can inject the required protobuf-jar from application layers. ### How was this patch tested? Pass the CIs and manual review. **BEFORE** ``` $ build/mvn dependency:tree -pl connector/kinesis-asl-assembly -Pkinesis-asl | grep protobuf-java ... [INFO] +- com.google.protobuf:protobuf-java:jar:2.6.1:provided ``` **AFTER** ``` $ build/mvn dependency:tree -pl connector/kinesis-asl-assembly -Pkinesis-asl | grep protobuf-java ... [INFO] | | +- com.google.protobuf:protobuf-java:jar:3.25.1:provided ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45096 from dongjoon-hyun/SPARK-47038. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When running with Kinesis Consumer Library (KCL), against a stream that contains aggregated data, the KCL needs access to protobuf to de-aggregate the records. Without this patch, that results in the following error message:
This PR upgrades the protobuf dependency within the kinesis-asl-assembly, and relocates that package (as not to conflict with Spark's use of 2.5.0), which fixes the above CNFE.
How was this patch tested?
Used kinesis word count example against a stream containing aggregated data.
See: SPARK-14421