-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-44442][MESOS] Remove Mesos support #43135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mridulm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 lines more, and it would have been an event 10k lines removed :-)
A satisfying operation, hahaha ~ |
|
spark/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala Lines 814 to 831 in f6c6acb
Does this part need to be fixed? |
In addition, does this line of comment still need to be retained? |
|
I noticed the TaskState.LOST comment, but was reluctant to actually totally remove handling of this event in case the comment was wrong. |
fine to me |
|
It looks like the tests actually passed but showing failed - I'm not quite sure what to make of the failure in 'reporting results'. |
|
Merged to master |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, late LGTM.
…il.Utils#getConfiguredLocalDirs` ### What changes were proposed in this pull request? This PR cleans up an unused local variables from `org.apache.spark.util.Utils#getConfiguredLocalDirs` function, It is no longer used after the support for Mesos was removed in SPARK-44442 (#43135). ### Why are the changes needed? Code clean up ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #44475 from LuciferYang/utils-useless. Lead-authored-by: yangjie01 <[email protected]> Co-authored-by: YangJie <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
…l in REST API ### What changes were proposed in this pull request? This PR aims to make `appArgs` and `environmentVariables` fields optional in REST API. ### Why are the changes needed? `appArgs` and `environmentVariables` became mandatory due to the Apache Mesos limitation at Spark 2.2.2. Technically, this is a revert of SPARK-22574. - #19966 Since Apache Spark 4.0 removed Mesos support, we don't need these requirements. - #43135 ### Does this PR introduce _any_ user-facing change? No because this is a relaxation of enforcement. ### How was this patch tested? Pass the CIs with the revised test case. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48316 from dongjoon-hyun/SPARK-49845. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
…Impl` ### What changes were proposed in this pull request? This PR aims to remove `TaskState.LOST` logic from `TaskSchedulerImpl` from Apache Spark 4.1.0. https://github.com/apache/spark/blob/6440bdec8af64f0d6b55d53eacb2591eaf8eb859/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L789-L790 ### Why are the changes needed? Since Apache Spark 4.0.0, `Apache Mesos` code is removed completely. Since `TaskState.LOST` is no longer used, we had better clean up this unused code to simplify the logic. - #43135 Please note that this PR didn't aim to remove `LOST` enum value from `TaskState` because it's exposed like the following although it's `private[spark]`. - https://spark.apache.org/docs/4.0.0-preview2/api/java/org/apache/spark/TaskState.html  ### Does this PR introduce _any_ user-facing change? No, behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49913 from dongjoon-hyun/SPARK-51184. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What changes were proposed in this pull request?
Remove Mesos resource manager support and docs, previously deprecated in Spark 3.2, for Spark 4.0.
Why are the changes needed?
Mesos is no longer supported and has been deprecated for several versions.
Does this PR introduce any user-facing change?
Other than the lack of Mesos support, no
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No