[SPARK-46498][CORE] Remove shuffleServiceEnabled from o.a.spark.util.Utils#getConfiguredLocalDirs
#44475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
o.a.spark.util.Utilso.a.spark.util.Utils
dongjoon-hyun
requested changes
Dec 25, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Sorry but let's not remove these Utils methods although they are private[spark]. There is no maintenance overhead for these util methods and these might be used by a new repository Spark Operator which is voted recently.
| * logic of locating the local directories according to deployment mode. | ||
| */ | ||
| def getConfiguredLocalDirs(conf: SparkConf): Array[String] = { | ||
| val shuffleServiceEnabled = conf.get(config.SHUFFLE_SERVICE_ENABLED) |
Member
There was a problem hiding this comment.
To be clear, this is enough for a valid PR. We can merge if we have only this removal.
LuciferYang
changed the title
o.a.spark.util.Utilso.a.spark.util.Utils#getConfiguredLocalDirs
Contributor
Author
OK |
dongjoon-hyun
approved these changes
Dec 26, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for updating this PR.
dongjoon-hyun
changed the title
o.a.spark.util.Utils#getConfiguredLocalDirsshuffleServiceEnabled from o.a.spark.util.Utils#getConfiguredLocalDirs
Contributor
Author
|
Thanks @dongjoon-hyun ~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR cleans up an unused local variables from
org.apache.spark.util.Utils#getConfiguredLocalDirsfunction, It is no longer used after the support for Mesos was removed in SPARK-44442 (#43135).Why are the changes needed?
Code clean up
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No