[SPARK-51184][CORE] Remove TaskState.LOST logic from TaskSchedulerImpl
#49913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Could you review this PR when you have some time, @viirya ? |
viirya
approved these changes
Feb 12, 2025
Member
|
Looks good to me. Thanks @dongjoon-hyun |
Member
Author
|
Thank you so much, @viirya ! |
Member
Author
|
Merged to master for Apache Spark 4.1.0. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 9, 2025
…dulerImpl#statusUpdate` ### What changes were proposed in this pull request? After SPARK-51184 (#49913), the variables `failedExecutor` and `reason` defined in the function `TaskSchedulerImpl#statusUpdate` are not reassigned after being initialized to `None`. https://github.com/apache/spark/blob/f40bf4dd7166e86ea5cc9962e8c5b68b88f8dcb5/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L783-L811 Therefore, `failedExecutor.isDefined` will always be false, and the following `if` branch will never be entered: https://github.com/apache/spark/blob/f40bf4dd7166e86ea5cc9962e8c5b68b88f8dcb5/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L812-L817. So, the this pr cleans it up. ### Why are the changes needed? Code cleanup. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #50218 from LuciferYang/ts-statusUpdate. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove
TaskState.LOSTlogic fromTaskSchedulerImplfrom Apache Spark 4.1.0.spark/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
Lines 789 to 790 in 6440bde
Why are the changes needed?
Since Apache Spark 4.0.0,
Apache Mesoscode is removed completely. SinceTaskState.LOSTis no longer used, we had better clean up this unused code to simplify the logic.Please note that this PR didn't aim to remove
LOSTenum value fromTaskStatebecause it's exposed like the following although it'sprivate[spark].Does this PR introduce any user-facing change?
No, behavior change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.