[SPARK-41754][UI] Add simple developer guides for UI Protobuf serializer#39270
Closed
gengliangwang wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-41754][UI] Add simple developer guides for UI Protobuf serializer#39270gengliangwang wants to merge 2 commits intoapache:masterfrom
gengliangwang wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
This is for the issue in #39192 (comment) |
cloud-fan
approved these changes
Dec 29, 2022
LuciferYang
reviewed
Dec 29, 2022
| * Developer guides: | ||
| * - Coding style: https://developers.google.com/protocol-buffers/docs/style | ||
| * - Use int64 for job/stage IDs, in case of future extension in Spark core. | ||
| * - Use `weakIntern` on string values in create new objects during deserialization. |
Contributor
There was a problem hiding this comment.
- Use
weakInternon string values in create new objects during deserialization.
This is very important. I think we need a refactor work to fix the current codes
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
panbingkun
approved these changes
Dec 29, 2022
Contributor
|
need re-trigger failed GA task @gengliangwang |
panbingkun
reviewed
Dec 29, 2022
|
|
||
| enum JobExecutionStatus { | ||
| UNSPECIFIED = 0; | ||
| JOB_EXECUTION_STATUS_UNSPECIFIED = 0; |
Contributor
There was a problem hiding this comment.
Is it more reasonable?
message Job {
enum JobExecutionStatus {
...
}
}
Contributor
There was a problem hiding this comment.
OK, Let us follow code style(https://developers.google.com/protocol-buffers/docs/style#enums):
techaddict
approved these changes
Dec 29, 2022
Member
Author
|
Merging to master |
gengliangwang
pushed a commit
that referenced
this pull request
Jan 19, 2023
…bjects during deserialization ### What changes were proposed in this pull request? The pr aims to use weakIntern on string values in create new objects during deserialization. ### Why are the changes needed? Following guid: #39270. <img width="587" alt="image" src="https://user-images.githubusercontent.com/15246973/209924939-779db183-f0a6-4f3b-aebf-cf00b6c95cf8.png"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes #39275 from panbingkun/SPARK-41759. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
UNSPECIFIEDin the enum JobExecutionStatus asJOB_EXECUTION_STATUS_UNSPECIFIEDWhy are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT