Skip to content

[SPARK-41754][UI] Add simple developer guides for UI Protobuf serializer #39270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengliangwang wants to merge 2 commits into from
Closed

[SPARK-41754][UI] Add simple developer guides for UI Protobuf serializer #39270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9115f63
add simple developer guide
gengliangwang Dec 29, 2022
cdec377
revise
gengliangwang Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,15 @@
syntax = "proto3";
package org.apache.spark.status.protobuf;

/**
* Developer guides:
* - Coding style: https://developers.google.com/protocol-buffers/docs/style
* - Use int64 for job/stage IDs, in case of future extension in Spark core.
* - Use `weakIntern` on string values in create new objects during deserialization.
Copy link
Contributor

@LuciferYang LuciferYang Dec 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use weakIntern on string values in create new objects during deserialization.

This is very important. I think we need a refactor work to fix the current codes

Copy link
Contributor

@LuciferYang LuciferYang Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @panbingkun @techaddict

Copy link
Contributor

@panbingkun panbingkun Dec 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/SPARK-41759 @LuciferYang @gengliangwang @techaddict

*/

enum JobExecutionStatus {
UNSPECIFIED = 0;
JOB_EXECUTION_STATUS_UNSPECIFIED = 0;
Copy link
Contributor

@panbingkun panbingkun Dec 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it more reasonable?

message Job {
   enum JobExecutionStatus {
      ...
   }
}

Copy link
Contributor

@panbingkun panbingkun Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, Let us follow code style(https://developers.google.com/protocol-buffers/docs/style#enums):
image

RUNNING = 1;
SUCCEEDED = 2;
FAILED = 3;
Expand Down