[SPARK-41705][CONNECT] Move generate_protos.sh to dev/#39211
[SPARK-41705][CONNECT] Move generate_protos.sh to dev/#39211tedyu wants to merge 1 commit intoapache:masterfrom
Conversation
|
cc @HyukjinKwon |
cec9cd6 to
5d17794
Compare
|
I tried to account for Though the above doesn't seem to work. |
|
I don't think it's worth moving it atm. It has a clear relationship to the contained code in the connect package. |
|
Actually maybe now it's time to consider moving these (including |
|
Let's also fix |
|
Should also better file a JIRA. |
dev/generate_protos.sh
Outdated
There was a problem hiding this comment.
Since we already did cd "$SPARK_HOME" above, I guess we won't need this change anyway (?)
|
the code gen checker failed: |
|
will take this over with moving related README.md together. |
|
#39338. I will add you as a co-author there. |
…and script to dev/ and Python documentation ### What changes were proposed in this pull request? This PR takes over #39211 and #38477 that proposes: - Move `connector/connect/dev/generate_protos.sh` → `dev/generate_protos.sh` to be consistent with other places - Move Python-specific development guides into `python/docs/source/development/testing.rst` ### Why are the changes needed? To keep the project structure and documentation consistent. ### Does this PR introduce _any_ user-facing change? Python-specific development guides for Spark Connect will be added in https://spark.apache.org/docs/latest/api/python/development/testing.html. ### How was this patch tested? I manually tested: ``` ./dev/generate_protos.sh ./dev/check-codegen-python.py ``` I also manually verified the Python documentation. Closes #39338 from HyukjinKwon/SPARK-41705. Lead-authored-by: Hyukjin Kwon <gurwls223@apache.org> Co-authored-by: Ted Yu <yuzhihong@gmail.com> Co-authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
What changes were proposed in this pull request?
This PR moves generate_protos.sh from
connector/connect/devtodevdirectory.Why are the changes needed?
connector/connect/devonly contains one script. Moving generate_protos.sh todevfollows practice for other scripts.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test suite.