[SPARK-40993][SPARK-41705][CONNECT] Move Spark Connect documentation and script to dev/ and Python documentation#39338
Closed
HyukjinKwon wants to merge 6 commits intoapache:masterfrom
Closed
[SPARK-40993][SPARK-41705][CONNECT] Move Spark Connect documentation and script to dev/ and Python documentation#39338HyukjinKwon wants to merge 6 commits intoapache:masterfrom
HyukjinKwon wants to merge 6 commits intoapache:masterfrom
Conversation
HyukjinKwon
commented
Jan 2, 2023
|
|
||
| ### Generate proto generated files for the Python client | ||
| 1. Install `buf version 1.11.0`: https://docs.buf.build/installation | ||
| 2. Run `pip install grpcio==1.48.1 protobuf==3.19.5 mypy-protobuf==3.3.0 googleapis-common-protos==1.56.4 grpcio-status==1.48.1` |
Member
Author
There was a problem hiding this comment.
This is already documented in https://spark.apache.org/docs/latest/api/python/development/contributing.html#environment-setup
HyukjinKwon
commented
Jan 2, 2023
| ## Development Topics | ||
|
|
||
| ### Generate proto generated files for the Python client | ||
| 1. Install `buf version 1.11.0`: https://docs.buf.build/installation |
Member
Author
There was a problem hiding this comment.
Moved to Environment Setup
HyukjinKwon
commented
Jan 2, 2023
| for compilation steps, please refer to [protobuf](https://github.com/protocolbuffers/protobuf) and [grpc-java](https://github.com/grpc/grpc-java). | ||
|
|
||
|
|
||
| ### Run Spark Shell |
Member
Author
There was a problem hiding this comment.
Move to python/docs/source/development/testing.rst
Member
Author
zhengruifeng
approved these changes
Jan 2, 2023
HyukjinKwon
force-pushed
the
SPARK-41705
branch
from
5302519 to
38a5224
Compare
Contributor
|
Maybe at least prefix the scripts with connect so that it's clearer where they belong to and not just a random code dump? |
Member
Author
|
SGTM. let me rename them |
HyukjinKwon
force-pushed
the
SPARK-41705
branch
from
50a0e60 to
fd3f4ac
Compare
Member
Author
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR takes over #39211 and #38477 that proposes:
connector/connect/dev/generate_protos.sh→dev/generate_protos.shto be consistent with other placespython/docs/source/development/testing.rstWhy are the changes needed?
To keep the project structure and documentation consistent.
Does this PR introduce any user-facing change?
Python-specific development guides for Spark Connect will be added in https://spark.apache.org/docs/latest/api/python/development/testing.html.
How was this patch tested?
I manually tested:
I also manually verified the Python documentation.