Skip to content

[SPARK-41705][CONNECT] Move generate_protos.sh to dev/ #39211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tedyu wants to merge 1 commit into from
Closed

[SPARK-41705][CONNECT] Move generate_protos.sh to dev/ #39211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion connector/connect/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ To use the release version of Spark Connect:
### Generate proto generated files for the Python client
1. Install `buf version 1.11.0`: https://docs.buf.build/installation
2. Run `pip install grpcio==1.48.1 protobuf==3.19.5 mypy-protobuf==3.3.0`
3. Run `./connector/connect/dev/generate_protos.sh`
3. Run `dev/generate_protos.sh`
4. Optional Check `./dev/check-codegen-python.py`

### Guidelines for new clients
Expand Down
4 changes: 2 additions & 2 deletions dev/check-codegen-python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def run_cmd(cmd):
def check_connect_protos():
print("Start checking the generated codes in pyspark-connect.")
with tempfile.TemporaryDirectory() as tmp:
run_cmd(f"{SPARK_HOME}/connector/connect/dev/generate_protos.sh {tmp}")
run_cmd(f"{SPARK_HOME}/dev/generate_protos.sh {tmp}")
result = filecmp.dircmp(
f"{SPARK_HOME}/python/pyspark/sql/connect/proto/",
tmp,
Expand Down Expand Up @@ -76,7 +76,7 @@ def check_connect_protos():
fail(
"Generated files for pyspark-connect are out of sync! "
"If you have touched files under connector/connect/src/main/protobuf, "
"please run ./connector/connect/dev/generate_protos.sh. "
"please run ./dev/generate_protos.sh. "
"If you haven't touched any file above, please rebase your PR against main branch."
)

Expand Down
2 changes: 1 addition & 1 deletion connector/connect/dev/generate_protos.sh → dev/generate_protos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ set -ex

if [[ $# -gt 1 ]]; then
echo "Illegal number of parameters."
echo "Usage: ./connector/connect/dev/generate_protos.sh [path]"
echo "Usage: ./dev/generate_protos.sh [path]"
exit -1
fi

Expand Down