[SPARK-40419][SQL][TESTS][FOLLOWUP] Remove results/udaf.sql.out #38919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@itholic Could you look at this PR since it is related to your PR (reviewed by @HyukjinKwon). |
Member
|
I verified manually. We use |
Contributor
|
Sorry for confirming late, LGTM. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? Remove the file `results/udaf.sql.out` because it is not generated anymore after apache#37873. ### Why are the changes needed? The duplicate file might confuse while searching some text in golden files. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the affected test suite: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" ``` Closes apache#38919 from MaxGekk/rm-udaf.sql.out. Authored-by: Max Gekk <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the file
results/udaf.sql.outbecause it is not generated anymore after #37873.Why are the changes needed?
The duplicate file might confuse while searching some text in golden files.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the affected test suite: