[SPARK-40419][SQL][TESTS] Integrate Grouped Aggregate Pandas UDFs into *.sql test cases #37873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @HyukjinKwon could you help me on review when you find some time ? |
HyukjinKwon
reviewed
Sep 19, 2022
HyukjinKwon
approved these changes
Sep 19, 2022
Member
|
Merged to master. |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
Sep 20, 2022
…o *.sql test cases ### What changes were proposed in this pull request? This PR proposes to integrate Grouped Aggregate Pandas UDF tests into *.sql test cases. This PR includes the fixes below: - Add `UDAFTestCase` into `SQLQueryTestSuite.scala` to test the UDAF related functions in sql. - Add `udaf` directory and create related sql test cases into this directory. - Generate golden files for new added sql test files. - Skip from `ThriftServerQueryTestSuite.scala` for now. - Fix minor typos. ### Why are the changes needed? To improve the test coverage, so prevent the potential bug in the future. ### Does this PR introduce _any_ user-facing change? No, it's test-only. ### How was this patch tested? Added sql test files and corresponding golden files. Closes apache#37873 from itholic/SPARK-40419. Authored-by: itholic <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
pushed a commit
that referenced
this pull request
Sep 20, 2022
… unavailable ### What changes were proposed in this pull request? This PR follow-up for #37873. The UDAF test should be skipped when pyspark, pandas and/or pyarrow is unavailable with proper message. ### Why are the changes needed? Skip the test properly when it's unavailable. ### Does this PR introduce _any_ user-facing change? No, it's test only. ### How was this patch tested? Manually test to be skipped when missing package.  Closes #37946 from itholic/SPARK-40419-followup. Authored-by: itholic <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 5, 2022
### What changes were proposed in this pull request? Remove the file `results/udaf.sql.out` because it is not generated anymore after #37873. ### Why are the changes needed? The duplicate file might confuse while searching some text in golden files. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the affected test suite: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" ``` Closes #38919 from MaxGekk/rm-udaf.sql.out. Authored-by: Max Gekk <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? Remove the file `results/udaf.sql.out` because it is not generated anymore after apache#37873. ### Why are the changes needed? The duplicate file might confuse while searching some text in golden files. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the affected test suite: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" ``` Closes apache#38919 from MaxGekk/rm-udaf.sql.out. Authored-by: Max Gekk <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to integrate Grouped Aggregate Pandas UDF tests into *.sql test cases.
This PR includes the fixes below:
UDAFTestCaseintoSQLQueryTestSuite.scalato test the UDAF related functions in sql.udafdirectory and create related sql test cases into this directory.ThriftServerQueryTestSuite.scalafor now.Why are the changes needed?
To improve the test coverage, so prevent the potential bug in the future.
Does this PR introduce any user-facing change?
No, it's test-only.
How was this patch tested?
Added sql test files and corresponding golden files.