[DO-NOT-MERGE] Exceptions without error classes in SQL golden files #37725
Conversation
MaxGekk
force-pushed
the
excep-without-error-classes
branch
from
068bd06 to
8a87f00
Compare
| { | ||
| "errorClass" : "LEGACY", | ||
| "messageParameters" : { | ||
| "message" : "requirement failed: concat_ws requires at least one argument.; line 1 pos 7" |
| { | ||
| "errorClass" : "LEGACY", | ||
| "messageParameters" : { | ||
| "message" : "requirement failed: format_string() should take at least 1 argument; line 1 pos 7" |
| { | ||
| "errorClass" : "LEGACY", | ||
| "messageParameters" : { | ||
| "message" : "The 'format' parameter of function 'to_binary' needs to be a string literal.; line 1 pos 7" |
| { | ||
| "errorClass" : "LEGACY", | ||
| "messageParameters" : { | ||
| "message" : "Reference 'b' is ambiguous, could be: x.b, y.b.; line 1 pos 21" |
| { | ||
| "errorClass" : "LEGACY", | ||
| "messageParameters" : { | ||
| "message" : "Reference 'b' is ambiguous, could be: x.b, y.b.; line 3 pos 14" |
| Literals of type 'not_supported' are currently not supported for the string type.; line 1 pos 7 | ||
| { | ||
| "errorClass" : "LEGACY", | ||
| "messageParameters" : { |
| Literals of type 'not_supported' are currently not supported for the interval year to month type.; line 1 pos 7 | ||
| { | ||
| "errorClass" : "LEGACY", | ||
| "messageParameters" : { |
| Literals of type 'not_supported' are currently not supported for the interval day to second type.; line 1 pos 7 | ||
| { | ||
| "errorClass" : "LEGACY", | ||
| "messageParameters" : { |
| { | ||
| "errorClass" : "LEGACY", | ||
| "messageParameters" : { | ||
| "message" : "Literals of type 'DAY' are currently not supported for the interval year to month type.; line 1 pos 7" |
| { | ||
| "errorClass" : "LEGACY", | ||
| "messageParameters" : { | ||
| "message" : "Literals of type 'MONTH' are currently not supported for the interval day to second type.; line 1 pos 7" |
|
@panbingkun @LuciferYang @itholic @cloud-fan @srielau @anchovYu @entong I changed the mechanism of generating SQL golden files in this PR to detect the exceptions that haven't been ported on error classes. There are still a few exceptions for which I opened the JIRAs: |
|
OK |
|
@MaxGekk Have all the issues mentioned in this pr been solved? |
Let me rebase it on the recent master and regenerate golden files, then we will see. |
|
All issues have been fixed. At the moment, all sql tests (in *.sql files) raise exception with error classes. I would propose to merge this change to detect exceptions that are not ported on error classes yet. @cloud-fan Are you ok with that? |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
3 participants
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?