Skip to content

[SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1102 #38725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panbingkun wants to merge 4 commits into from
Closed

[SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1102 #38725

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
881fb3c
[SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEM…
panbingkun Nov 19, 2022
3d7c66f
[SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEM…
panbingkun Nov 21, 2022
6e7f4ff
[SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEM…
panbingkun Nov 23, 2022
0e433eb
[SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEM…
panbingkun Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions core/src/main/resources/error/error-classes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,11 @@
],
"sqlState" : "42000"
},
"INVALID_EXTRACT_FIELD" : {
"message" : [
"Literals of the type <field> are currently not supported for the <sourceDataType> type."
Copy link
Member

@MaxGekk MaxGekk Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the error message more clear and precise. Let's talk specifically about the invalid extract field.

Copy link
Contributor Author

@panbingkun panbingkun Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

]
},
"INVALID_FIELD_NAME" : {
"message" : [
"Field name <fieldName> is invalid: <path> is not a struct."
Expand Down Expand Up @@ -2195,11 +2200,6 @@
"Invalid value for the '<argName>' parameter of function '<funcName>': <invalidValue>.<endingMsg>."
]
},
"_LEGACY_ERROR_TEMP_1102" : {
"message" : [
"Literals of type '<field>' are currently not supported for the <srcDataType> type."
]
},
"_LEGACY_ERROR_TEMP_1103" : {
"message" : [
"Unsupported component type <clz> in arrays."
Expand Down
6 changes: 3 additions & 3 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,10 +1073,10 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase {

def literalTypeUnsupportedForSourceTypeError(field: String, source: Expression): Throwable = {
new AnalysisException(
errorClass = "_LEGACY_ERROR_TEMP_1102",
errorClass = "INVALID_EXTRACT_FIELD",
messageParameters = Map(
"field" -> field,
"srcDataType" -> source.dataType.catalogString))
"field" -> toSQLId(field),
"sourceDataType" -> toSQLType(source.dataType)))
}

def arrayComponentTypeUnsupportedError(clz: Class[_]): Throwable = {
Expand Down
36 changes: 17 additions & 19 deletions sql/core/src/test/resources/sql-tests/results/extract.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ select extract(not_supported from c) from t
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
Literals of type 'not_supported' are currently not supported for the string type.; line 1 pos 7
[INVALID_EXTRACT_FIELD] Literals of the type `not_supported` are currently not supported for the "STRING" type.; line 1 pos 7


-- !query
Expand All @@ -326,7 +326,7 @@ select extract(not_supported from i) from t
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
Literals of type 'not_supported' are currently not supported for the interval year to month type.; line 1 pos 7
[INVALID_EXTRACT_FIELD] Literals of the type `not_supported` are currently not supported for the "INTERVAL YEAR TO MONTH" type.; line 1 pos 7


-- !query
Expand All @@ -335,8 +335,7 @@ select extract(not_supported from j) from t
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
Literals of type 'not_supported' are currently not supported for the interval day to second type.; line 1 pos 7

[INVALID_EXTRACT_FIELD] Literals of the type `not_supported` are currently not supported for the "INTERVAL DAY TO SECOND" type.; line 1 pos 7

-- !query
select date_part('year', c), date_part('year', ntz), date_part('year', i) from t
Expand Down Expand Up @@ -649,10 +648,10 @@ struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
"errorClass" : "_LEGACY_ERROR_TEMP_1102",
"errorClass" : "INVALID_EXTRACT_FIELD",
"messageParameters" : {
"field" : "not_supported",
"srcDataType" : "string"
"field" : "`not_supported`",
"sourceDataType" : "\"STRING\""
},
"queryContext" : [ {
"objectType" : "",
Expand Down Expand Up @@ -924,7 +923,7 @@ select extract(DAY from interval '2-1' YEAR TO MONTH)
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
Literals of type 'DAY' are currently not supported for the interval year to month type.; line 1 pos 7
[INVALID_EXTRACT_FIELD] Literals of the type `DAY` are currently not supported for the "INTERVAL YEAR TO MONTH" type.; line 1 pos 7


-- !query
Expand All @@ -934,10 +933,10 @@ struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
"errorClass" : "_LEGACY_ERROR_TEMP_1102",
"errorClass" : "INVALID_EXTRACT_FIELD",
"messageParameters" : {
"field" : "DAY",
"srcDataType" : "interval year to month"
"field" : "`DAY`",
"sourceDataType" : "\"INTERVAL YEAR TO MONTH\""
},
"queryContext" : [ {
"objectType" : "",
Expand All @@ -956,10 +955,10 @@ struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
"errorClass" : "_LEGACY_ERROR_TEMP_1102",
"errorClass" : "INVALID_EXTRACT_FIELD",
"messageParameters" : {
"field" : "not_supported",
"srcDataType" : "interval year to month"
"field" : "`not_supported`",
"sourceDataType" : "\"INTERVAL YEAR TO MONTH\""
},
"queryContext" : [ {
"objectType" : "",
Expand Down Expand Up @@ -1081,8 +1080,7 @@ select extract(MONTH from interval '123 12:34:56.789123123' DAY TO SECOND)
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
Literals of type 'MONTH' are currently not supported for the interval day to second type.; line 1 pos 7

[INVALID_EXTRACT_FIELD] Literals of the type `MONTH` are currently not supported for the "INTERVAL DAY TO SECOND" type.; line 1 pos 7

-- !query
select date_part('not_supported', interval '123 12:34:56.789123123' DAY TO SECOND)
Expand All @@ -1091,10 +1089,10 @@ struct<>
-- !query output
org.apache.spark.sql.AnalysisException
{
"errorClass" : "_LEGACY_ERROR_TEMP_1102",
"errorClass" : "INVALID_EXTRACT_FIELD",
"messageParameters" : {
"field" : "not_supported",
"srcDataType" : "interval day to second"
"field" : "`not_supported`",
"sourceDataType" : "\"INTERVAL DAY TO SECOND\""
},
"queryContext" : [ {
"objectType" : "",
Expand Down