[SPARK-40061][SQL][DOCS] Document cast of ANSI intervals #37495
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
HyukjinKwon
approved these changes
Aug 13, 2022
Member
Author
|
Merging to master. Thank you, @HyukjinKwon for review. |
cloud-fan
reviewed
Aug 15, 2022
| +---+ | ||
| ``` | ||
|
|
||
| #### Rounding in cast |
Contributor
There was a problem hiding this comment.
is it also the behavior of casting decimal to int?
Member
Author
There was a problem hiding this comment.
No, casting to int just removes the fraction part. @gengliangwang @srielau Maybe you what SQL standard says about rounding to int?
Contributor
There was a problem hiding this comment.
casting to int behavior is "implementation dependent" The standard makes no decision here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to update the doc page https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html#cast about new behaviour of CAST introduced by the following PRs:
Why are the changes needed?
To inform Spark SQL about new behaviour of
CAST.Does this PR introduce any user-facing change?
No.
How was this patch tested?
By building Spark SQL docs and check them manually: