[SPARK-40014][SQL] Support cast of decimals to ANSI intervals #37466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
MaxGekk
changed the title
Member
Author
|
@HyukjinKwon @cloud-fan @gengliangwang Could you review this PR, please. |
cloud-fan
reviewed
Aug 12, 2022
| d: Decimal, p: Int, s: Int, startField: Byte, endField: Byte): Int = { | ||
| try { | ||
| val months = if (endField == YEAR) d.toBigDecimal * MONTHS_PER_YEAR else d.toBigDecimal | ||
| months.setScale(0, BigDecimal.RoundingMode.HALF_UP).toIntExact |
Contributor
There was a problem hiding this comment.
do we have a sql reference doc for cast? we should mention the rounding behavior.
Member
Author
There was a problem hiding this comment.
We have the doc for cast: https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html#cast but it says that Spark doesn't support cast of intervals to numerics. Let me open a PR and document recent changes in casting of ANSI intervals.
Member
Author
There was a problem hiding this comment.
@cloud-fan I opened the PR #37495 which updates the doc.
cloud-fan
approved these changes
Aug 12, 2022
Member
Author
|
Merging to master. Thank you, @cloud-fan for review. |
MaxGekk
added a commit
that referenced
this pull request
Aug 13, 2022
### What changes were proposed in this pull request? In the PR, I propose to update the doc page https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html#cast about new behaviour of CAST introduced by the following PRs: 1. [[SPARK-40008][SQL] Support casting of integrals to ANSI intervals](#37442) 2. [[SPARK-39451][SQL] Support casting intervals to integrals in ANSI mode](#36811) 3. [[SPARK-39470][SQL] Support cast of ANSI intervals to decimals](#36857) 4. [[SPARK-40014][SQL] Support cast of decimals to ANSI intervals](#37466) <img width="1004" alt="Screenshot 2022-08-12 at 15 00 10" src="https://user-images.githubusercontent.com/1580697/184349887-700c64f6-e9c8-40c4-85cc-a77072506cf5.png"> ### Why are the changes needed? To inform Spark SQL about new behaviour of `CAST`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By building Spark SQL docs and check them manually: ``` $ SKIP_SCALADOC=1 SKIP_PYTHONDOC=1 SKIP_RDOC=1 bundle exec jekyll build ``` Closes #37495 from MaxGekk/doc-interval-cast. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to support casts of decimals to ANSI intervals, and follow the SQL standard:
Why are the changes needed?
To improve user experience with Spark SQL, and to conform to the SQL standard.
Does this PR introduce any user-facing change?
No, it just extends existing behavior of casts.
Before:
After:
How was this patch tested?
By running new tests: