[SPARK-38131][SQL] Use error classes in user-facing exceptions only #35445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
commented
Feb 8, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Outdated
Show resolved
Hide resolved
MaxGekk
commented
Feb 8, 2022
| """.stripMargin.trim + " of the field in the target object") | ||
| } | ||
|
|
||
| test("UNSUPPORTED_FEATURE: UpCast only support DecimalType as AbstractDataType") { |
Member
Author
There was a problem hiding this comment.
The test was added by #35366 recently while porting on error classes. So, it is safe to remove it.
MaxGekk
commented
Feb 8, 2022
| result | ||
| } else { | ||
| throw QueryExecutionErrors.rowFromCSVParserNotExpectedError | ||
| throw new IllegalStateException("Expected one row from CSV parser.") |
Member
Author
There was a problem hiding this comment.
I do believe this shouldn't happen. cc @HyukjinKwon
cloud-fan
reviewed
Feb 10, 2022
|
|
||
| case UpCast(_, target, _) if target != DecimalType && !target.isInstanceOf[DataType] => | ||
| throw QueryCompilationErrors.unsupportedAbstractDataTypeForUpCastError(target) | ||
| throw new AnalysisException( |
Contributor
There was a problem hiding this comment.
For internal errors, can we throw IllegalStateException?
cloud-fan
approved these changes
Feb 10, 2022
Member
Author
|
Merging to master. Thank you, @HyukjinKwon and @cloud-fan for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to remove the error class
ROW_FROM_CSV_PARSER_NOT_EXPECTEDand don't use the error classUNSUPPORTED_FEATUREin an up-cast exception which is an internal one.Why are the changes needed?
The error classes are supposed to be used in user-facing errors/exceptions only. It doesn't make sense to introduce/use them in internal errors.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running existing test suites.