[SPARK-29453][WEBUI] Improve tooltips information for SQL tab. #26259

07ARB · 2019-10-25T18:04:21Z

What changes were proposed in this pull request?

Adding tooltip to SQL tab for better usability.

Why are the changes needed?

There are a few common points of confusion in the UI that could be clarified with tooltips. We
should add tooltips to explain.

Does this PR introduce any user-facing change?

yes.

How was this patch tested?

Manual test.

07ARB · 2019-10-25T18:17:00Z

@dongjoon-hyun , @shahidki31 , @srowen (All the comments given in this PR #26216(closed) i have fixed and raised new PR).

sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala

shahidki31 · 2019-10-25T18:24:04Z

Jenkins, test this please

srowen

I don't think this adds enough to justify. There just isn't much to explain about these.
(PS normally you push more commits to your previous branch rather than make a new one and PR, so as not to fork the review)

sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala

07ARB · 2019-10-25T18:52:05Z

I don't think this adds enough to justify. There just isn't much to explain about these.
(PS normally you push more commits to your previous branch rather than make a new one and PR, so as not to fork the review)
Thank you @srowen , from next time onward i will take care of it.

srowen · 2019-10-25T19:08:37Z

If we can't come up with meaningful tooltips, why add them? I don't know if it is necessary here.

07ARB · 2019-10-25T19:17:48Z

If we can't come up with meaningful tooltips, why add them? I don't know if it is necessary here.

ok then i will remove it but i shaw in Executors page they are displaying tooltips as header name,please check this image

srowen · 2019-10-25T19:21:19Z

Yep I think those tooltips are not useful and should be removed.

07ARB · 2019-10-25T19:24:20Z

Yep I think those tooltips are not useful and should be removed.

ok, i will remove the tooltips.

@srowen , i think this 3 is ok, please check

and others i have removed.

### What changes were proposed in this pull request? Adding tooltip to SQL tab for better usability. https://issues.apache.org/jira/browse/SPARK-29453 ### Why are the changes needed? There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain. ### Does this PR introduce any user-facing change? yes. ### How was this patch tested? 1) Unit tests (written unit test cases to verify changes). 2) Manual test. Authored-by: Ankit Raj Boudh <ankitrajboudh@gmail.com> fixed review comments

07ARB · 2019-10-25T22:10:50Z

@dongjoon-hyun ,@srowen, I have fixed all the comments please check it. I think now every think is ok.

sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala

Tooltips not required for each row review comments fixed.

07ARB · 2019-10-27T05:23:42Z

@shahidki31 and @srowen now I think fixed is ok?

sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala

srowen

I just don't think this adds enough to justify more tooltips popping up. It isn't required to have every item with a tooltip.

07ARB · 2019-10-27T19:44:22Z

@srowen, if headerTooltip is empty then no tooltips popup will display.

srowen · 2019-10-28T13:24:13Z

To be clear, I would not merge this.

07ARB · 2019-10-28T19:07:34Z

Ok then I need add check point, if header is empty then no need to add tooltips, then it's ok?

07ARB · 2019-10-28T19:09:05Z

#26259 (comment)
That's OK @srowen, you just help me to correct the code I will do it.

07ARB · 2019-11-06T18:41:11Z

@srowen , so this issue not require to fix ? , (if yes then i will commit in jira not require to fix, so that reporter will cancel that jira)

srowen · 2019-11-06T18:46:57Z

As I say here and elsewhere, I don't think most of these columns have anything meaningful to say in a tooltop. Duration, maybe, if it's not clear what the end and start times are. But no I do not think we need most of what's being proposed here.

07ARB · 2019-11-06T18:49:42Z

ok then for Duration i will add the tooltip for other no need to add that is ok @srowen ?

srowen · 2019-11-06T18:53:42Z

As long as it's not saying "the time taken to X", maybe so. You'd have to figure out how to correctly describe the start and end time it's measuring.

07ARB · 2019-11-06T18:58:50Z

ok i will check this point (how to correctly describe the start and end time it's measuring.)

07ARB · 2019-11-09T18:52:41Z

@srowen , this is how we are calculating duration
val duration = executionUIData.completionTime.map(_.getTime())
.getOrElse(currentTime) - submissionTime

and i referred this PR [SPARK-29019][WebUI] Improve tooltip JDBC/ODBC Server tab #25723

Tooltips for "Duration": "Difference between sql query execution finish time and submission time".

If this suggestion ok then i will submit PR for this

07ARB · 2019-11-09T18:55:25Z

@srowen , please review this PR also if both is ok then i will start working on other issue.
#26263

srowen · 2019-11-10T19:02:01Z

I don't think that's quite accurate. It's either the time until the finish time, or the current time if still executing. How about more like "Time from query submission to completion (or if still executing, time since submission)". You/we might also review other similar tooltips about duration to see if we can make the wording more standard, but something like that.

07ARB · 2019-11-11T12:04:24Z

#26259 (comment) @srowen , sure i will check other places also.

07ARB · 2019-11-12T17:54:10Z

@srowen, I checked the code and found Total 5 pages of Spark showing Duration field inside table , Please check all the screenshot :

Job page :
Stage page :

SQL page :

JDBC/ODBC Server :

Master Spark UI :

Note : Active Driver and Completed Driver under master spark ui page also "Duration field is there."

07ARB · 2019-11-12T18:18:15Z

@srowen , I think based on feature "Duration" field tooltips will change.
I will form tooltips (Only for "Duration" field) for above mention screenshot.

shahidki31 reviewed Oct 25, 2019

View reviewed changes

sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala Outdated Show resolved Hide resolved

sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala Outdated Show resolved Hide resolved

srowen reviewed Oct 25, 2019

View reviewed changes

sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala Outdated Show resolved Hide resolved

sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala Outdated Show resolved Hide resolved

07ARB force-pushed the SPARK-29453 branch from 39bba6e to 03d9bc5 Compare October 25, 2019 18:44

07ARB requested a review from srowen October 25, 2019 19:02

07ARB force-pushed the SPARK-29453 branch from 03d9bc5 to e84f7c8 Compare October 25, 2019 21:01

07ARB force-pushed the SPARK-29453 branch from e84f7c8 to 3b2dbaf Compare October 25, 2019 21:05

dongjoon-hyun added the WEB UI label Oct 25, 2019

dongjoon-hyun reviewed Oct 26, 2019

View reviewed changes

sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala Outdated Show resolved Hide resolved

GitHub Action Error fixed.

5dce8d1

07ARB requested a review from dongjoon-hyun October 26, 2019 09:04

shahidki31 reviewed Oct 26, 2019

View reviewed changes

sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala Outdated Show resolved Hide resolved

07ARB added 2 commits October 27, 2019 07:25

Review comments fixed.

d69e98a

Update AllExecutionsPage.scala

731495f

Tooltips not required for each row review comments fixed.

shahidki31 reviewed Oct 27, 2019

View reviewed changes

sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala Show resolved Hide resolved

srowen reviewed Oct 27, 2019

View reviewed changes

07ARB requested a review from srowen October 28, 2019 12:44

srowen closed this Nov 6, 2019

07ARB mentioned this pull request Nov 22, 2019

[SPARK-29453][WEBUI] Improve tooltips information for SQL tab. #26641

Closed

[SPARK-29453][WEBUI] Improve tooltips information for SQL tab. #26259

[SPARK-29453][WEBUI] Improve tooltips information for SQL tab. #26259

Uh oh!

Conversation

07ARB commented Oct 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

07ARB commented Oct 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shahidki31 commented Oct 25, 2019

Uh oh!

srowen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

07ARB commented Oct 25, 2019

Uh oh!

srowen commented Oct 25, 2019

Uh oh!

07ARB commented Oct 25, 2019

Uh oh!

srowen commented Oct 25, 2019

Uh oh!

07ARB commented Oct 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

07ARB commented Oct 25, 2019

Uh oh!

Uh oh!

Uh oh!

07ARB commented Oct 27, 2019

Uh oh!

Uh oh!

srowen left a comment

Choose a reason for hiding this comment

Uh oh!

07ARB commented Oct 27, 2019

Uh oh!

srowen commented Oct 28, 2019

Uh oh!

07ARB commented Oct 28, 2019

Uh oh!

07ARB commented Oct 28, 2019

Uh oh!

07ARB commented Nov 6, 2019

Uh oh!

srowen commented Nov 6, 2019

Uh oh!

07ARB commented Nov 6, 2019

Uh oh!

srowen commented Nov 6, 2019

Uh oh!

07ARB commented Nov 6, 2019

Uh oh!

07ARB commented Nov 9, 2019

Uh oh!

07ARB commented Nov 9, 2019

Uh oh!

srowen commented Nov 10, 2019

Uh oh!

07ARB commented Nov 11, 2019

Uh oh!

07ARB commented Nov 12, 2019

Uh oh!

07ARB commented Nov 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

07ARB commented Oct 25, 2019 •

edited

Loading

07ARB commented Oct 25, 2019 •

edited

Loading

07ARB commented Oct 25, 2019 •

edited

Loading

07ARB commented Nov 12, 2019 •

edited

Loading