-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29453][WEBUI] Improve tooltips information for SQL tab. #26641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@srowen , if this PR is ok , then please merge it to master. |
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
Outdated
Show resolved
Hide resolved
|
Test build #4944 has finished for PR 26641 at commit
|
|
Test build #4948 has finished for PR 26641 at commit
|
|
@srowen , Thank you , for your good guidance, your guidance will motivate me to contribute more in spark community. |
|
I checked failure test cases not related to this PR |
|
Test build #4953 has finished for PR 26641 at commit
|
|
Test build #4954 has finished for PR 26641 at commit
|
|
Test build #4956 has finished for PR 26641 at commit
|
|
Test build #4959 has finished for PR 26641 at commit
|
|
Hm, I really can't figure out why those tests are failing. It looks clearly unrelated, but consistent. And I don't see the failure in other PR builds that seem to touch sql/core. |
|
@srowen ,No problem i will check why it's failing. |
|
retest this please |
|
Test build #114810 has finished for PR 26641 at commit
|
|
@HyukjinKwon , Thank you |
|
@srowen , all test passed , i think now it's ok |
|
Merged to master |
### What changes were proposed in this pull request? Adding tooltip to SQL tab for better usability. ### Why are the changes needed? There are a few common points of confusion in the UI that could be clarified with tooltips. We should add tooltips to explain. ### Does this PR introduce any user-facing change? yes.  ### How was this patch tested? Manual test. Closes apache#26641 from 07ARB/SPARK-29453. Authored-by: 07ARB <[email protected]> Signed-off-by: Sean Owen <[email protected]>
What changes were proposed in this pull request?
Adding tooltip to SQL tab for better usability.
Why are the changes needed?
There are a few common points of confusion in the UI that could be clarified with tooltips. We
should add tooltips to explain.
Does this PR introduce any user-facing change?
yes.

How was this patch tested?
Manual test.