Skip to content

[SPARK-29453][WEBUI] Improve tooltips information for SQL tab. #26259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
07ARB wants to merge 4 commits into from
Closed

[SPARK-29453][WEBUI] Improve tooltips information for SQL tab. #26259

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b2dbaf
[SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
07ARB Oct 25, 2019
5dce8d1
GitHub Action Error fixed.
07ARB Oct 26, 2019
d69e98a
Review comments fixed.
07ARB Oct 27, 2019
731495f
Update AllExecutionsPage.scala
07ARB Oct 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,11 @@ private[ui] class ExecutionPagedTable(
}
}

val headerNameWithTooltips: Map[String, String] = Map(
"ID" -> "Execution ID of the SQL query.",
"Description" -> "The description links to the query details page",
"Duration" -> "Difference between start time and close time.")

val sortableColumnHeaders = executionHeadersAndCssClasses.filter {
case (_, sortable) => sortable
}.map { case (title, _) => title }
Expand All @@ -298,6 +303,7 @@ private[ui] class ExecutionPagedTable(

val headerRow: Seq[Node] = {
executionHeadersAndCssClasses.map { case (header, sortable) =>
val headerTooltip = headerNameWithTooltips.getOrElse(header, "")
if (header == sortColumn) {
val headerLink = Unparsed(
parameterPath +
Expand All @@ -309,7 +315,8 @@ private[ui] class ExecutionPagedTable(

<th>
<a href={headerLink}>
{header}<span>
<span data-toggle="tooltip" data-placement="top" title={headerTooltip}>
{header}</span><span>
&nbsp;{Unparsed(arrow)}
</span>
</a>
Expand All @@ -324,12 +331,16 @@ private[ui] class ExecutionPagedTable(

<th>
<a href={headerLink}>
{header}
<span data-toggle="tooltip" data-placement="top" title={headerTooltip}>
{header}
</span>
</a>
</th>
} else {
<th>
{header}
<span data-toggle="tooltip" data-placement="top" title={headerTooltip}>
{header}
</span>
</th>
}
}
Expand Down