Skip to content

[SPARK-26212][Build][test-maven] Upgrade maven version to 3.6.0 #23177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kiszk wants to merge 2 commits into from
Closed

[SPARK-26212][Build][test-maven] Upgrade maven version to 3.6.0 #23177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5587b5
initial commit
kiszk Nov 29, 2018
aa25833
address review comments
kiszk Dec 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/appveyor-install-dependencies.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ if (!(Test-Path $tools)) {
# ========================== Maven
Push-Location $tools

$mavenVer = "3.5.4"
$mavenVer = "3.6.0"
Start-FileDownload "https://archive.apache.org/dist/maven/maven-3/$mavenVer/binaries/apache-maven-$mavenVer-bin.zip" "maven.zip"

# extract
Expand Down
2 changes: 1 addition & 1 deletion docs/building-spark.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ redirect_from: "building-with-maven.html"
## Apache Maven

The Maven-based build is the build of reference for Apache Spark.
Building Spark using Maven requires Maven 3.5.4 and Java 8.
Building Spark using Maven requires Maven 3.6.0 and Java 8.
Note that support for Java 7 was removed as of Spark 2.2.0.

### Setting up Maven's Memory Usage
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
<java.version>1.8</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<maven.version>3.5.4</maven.version>
<maven.version>3.6.0</maven.version>
Copy link
Member

@HyukjinKwon HyukjinKwon Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiszk, I think we should update here as well https://github.com/apache/spark/blob/master/docs/building-spark.md#apache-maven (see #22781)

Copy link
Member

@srowen srowen Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wouldn't hurt, though I suspect the project continues to build with Maven 3.5.4 for a long while.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for updating the doc, too.

<sbt.project.name>spark</sbt.project.name>
<slf4j.version>1.7.16</slf4j.version>
<log4j.version>1.2.17</log4j.version>
Expand Down