[MINOR][DOC] Update the building doc to use Maven 3.5.4 and Java 8 only #22781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Oct 20, 2018
dongjoon-hyun
commented
Oct 20, 2018
docs/building-spark.md
Outdated
|
|
||
| The Maven-based build is the build of reference for Apache Spark. | ||
| Building Spark using Maven requires Maven 3.3.9 or newer and Java 8+. | ||
| Building Spark using Maven requires Maven 3.3.9 or newer and Java 8. |
Member
Author
There was a problem hiding this comment.
Ur, @kiszk and @cloud-fan , @HyukjinKwon .
It seems to be Maven version is also outdated. We updated Maven version in #21905 and #21920 .
Should we change it together? Or, Maven 3.3.9 is still valid to building Spark?
Contributor
There was a problem hiding this comment.
let's change to the expected maven version, thanks!
|
Test build #97637 has finished for PR 22781 at commit
|
dongjoon-hyun
changed the title
Java 8+
dongjoon-hyun
commented
Oct 20, 2018
|
|
||
| The Maven-based build is the build of reference for Apache Spark. | ||
| Building Spark using Maven requires Maven 3.3.9 or newer and Java 8+. | ||
| Building Spark using Maven requires Maven 3.5.4 and Java 8. |
Member
Author
There was a problem hiding this comment.
Maven 3.5.4 is the latest one and there is no newer version for now. We cannot guarantee the newer Maven work or not.
|
Test build #97639 has finished for PR 22781 at commit
|
felixcheung
approved these changes
Oct 20, 2018
Member
Author
|
Thank you for review, @HyukjinKwon , @cloud-fan , @felixcheung . |
Member
Author
|
Merged to master/branch-2.4. |
asfgit
pushed a commit
that referenced
this pull request
Oct 20, 2018
## What changes were proposed in this pull request? Since we didn't test Java 9 ~ 11 up to now in the community, fix the document to describe Java 8 only. ## How was this patch tested? N/A (This is a document only change.) Closes #22781 from dongjoon-hyun/SPARK-JDK-DOC. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit fc9ba9d) Signed-off-by: Dongjoon Hyun <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Since we didn't test Java 9 ~ 11 up to now in the community, fix the document to describe Java 8 only. ## How was this patch tested? N/A (This is a document only change.) Closes apache#22781 from dongjoon-hyun/SPARK-JDK-DOC. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since we didn't test Java 9 ~ 11 up to now in the community, fix the document to describe Java 8 only.
How was this patch tested?
N/A (This is a document only change.)