[SPARK-26212][Build][test-maven] Upgrade maven version to 3.6.0 #23177
Conversation
|
Test build #99437 has finished for PR 23177 at commit
|
|
retest this please |
|
That's fine but we need to also update build/mvn to download and use the same version. |
|
I thought that it is automatically done by |
|
Test build #99464 has finished for PR 23177 at commit
|
|
Ah, that's the second time I've forgotten this. Yes looks good to me. |
|
Test build #4447 has finished for PR 23177 at commit
|
| <maven.compiler.source>${java.version}</maven.compiler.source> | ||
| <maven.compiler.target>${java.version}</maven.compiler.target> | ||
| <maven.version>3.5.4</maven.version> | ||
| <maven.version>3.6.0</maven.version> |
There was a problem hiding this comment.
@kiszk, I think we should update here as well https://github.com/apache/spark/blob/master/docs/building-spark.md#apache-maven (see #22781)
There was a problem hiding this comment.
That wouldn't hurt, though I suspect the project continues to build with Maven 3.5.4 for a long while.
There was a problem hiding this comment.
+1 for updating the doc, too.
|
adding @dongjoon-hyun |
|
Thank you for pinging me, @HyukjinKwon . |
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
LGTM except for the doc issue.
I also tested with Scala-2.11 Maven for safety. It looks okay.
|
Oh, @kiszk . Could you update AppVoyer script together? AppVoyer script still uses a static version number unlike with |
|
Sure, updated. Thanks for letting know them. |
|
Test build #99538 has finished for PR 23177 at commit
|
|
Merging to master. I've been using 3.6.0 on the command line for a while and it's fine. Note that if you use your local mvn in IntelliJ, it seems to have some incompatibility with the current latest 2018.13.1 release. It's no big deal, falling back to its internal 3.3.9 version works fine. |
## What changes were proposed in this pull request? This PR updates maven version from 3.5.4 to 3.6.0. The release note of the 3.6.0 is [here](https://maven.apache.org/docs/3.6.0/release-notes.html). From [the release note of the 3.6.0](https://maven.apache.org/docs/3.6.0/release-notes.html), the followings are new features: 1. There had been issues related to the project discoverytime which has been increased in previous version which influenced some of our users. 1. The output in the reactor summary has been improved. 1. There was an issue related to the classpath ordering. ## How was this patch tested? Existing tests Closes apache#23177 from kiszk/SPARK-26212. Authored-by: Kazuaki Ishizaki <[email protected]> Signed-off-by: Sean Owen <[email protected]>
5 participants
What changes were proposed in this pull request?
This PR updates maven version from 3.5.4 to 3.6.0. The release note of the 3.6.0 is here.
From the release note of the 3.6.0, the followings are new features:
How was this patch tested?
Existing tests