[ Issue 13479 ] Fixed internal topic effect by InactiveTopicPolicy. #13611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codelipenghui @ericsyh @eolivelli @BewareMyPower @Technoboy- PTAL :) Another things: Although this PR can fix the issue #13479, But I have some advice as below:
|
|
/pulsarbot rerun-failure-checks |
liudezhi2098
reviewed
Jan 5, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java
Show resolved
Hide resolved
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
codelipenghui
approved these changes
Jan 12, 2022
|
@mattisonchao There are many conflicts with branch-2.8, could you please help push a new PR to fix the problem of branch-2.8? |
|
Sure, I will fix it ASAP
…On Tue, Jan 18, 2022 at 17:39, lipenghui ***@***.***> wrote:
@mattisonchao <https://github.com/mattisonchao> There are many conflicts
with branch-2.8, could you please help push a new PR to fix the problem of
branch-2.8?
—
Reply to this email directly, view it on GitHub
<#13611 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR2NWC2IWTN3BMOTERE7HYLUWUYMNANCNFSM5LI4UYFA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
2 tasks
|
work done. |
1 task
1 task
codelipenghui
pushed a commit
that referenced
this pull request
Mar 14, 2022
…gger compaction. (#14643) ### Motivation When create persistent topic, create compaction subscription(line-1395) is before topic `initialize`(line-1397), it's better to do this after `initialize`: https://github.com/apache/pulsar/blob/ad2cc2d38280b7dd0f056ee981ec8d3b157e3526/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1391-L1398 If we change this part, we can optimize the heartbeat topic not trigger the compaction. #13611 has made the heartbeat topic as a system topic to avoid deleting by GC. However, system topic is compacted by default. But the heartbeat topic sends msg without a key, so trigger compaction is meaningful. So it's better to skip the heartbeat topic to do the compaction. ### Modification - Move `preCreateSubscriptionForCompactionIfNeeded` after `initialize`. - Add heartbeat topic not trigger compaction.
codelipenghui
pushed a commit
that referenced
this pull request
Apr 19, 2022
…gger compaction. (#14643) ### Motivation When create persistent topic, create compaction subscription(line-1395) is before topic `initialize`(line-1397), it's better to do this after `initialize`: https://github.com/apache/pulsar/blob/ad2cc2d38280b7dd0f056ee981ec8d3b157e3526/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1391-L1398 If we change this part, we can optimize the heartbeat topic not trigger the compaction. #13611 has made the heartbeat topic as a system topic to avoid deleting by GC. However, system topic is compacted by default. But the heartbeat topic sends msg without a key, so trigger compaction is meaningful. So it's better to skip the heartbeat topic to do the compaction. ### Modification - Move `preCreateSubscriptionForCompactionIfNeeded` after `initialize`. - Add heartbeat topic not trigger compaction. (cherry picked from commit d02bd73)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…gger compaction. (apache#14643) ### Motivation When create persistent topic, create compaction subscription(line-1395) is before topic `initialize`(line-1397), it's better to do this after `initialize`: https://github.com/apache/pulsar/blob/ad2cc2d38280b7dd0f056ee981ec8d3b157e3526/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1391-L1398 If we change this part, we can optimize the heartbeat topic not trigger the compaction. apache#13611 has made the heartbeat topic as a system topic to avoid deleting by GC. However, system topic is compacted by default. But the heartbeat topic sends msg without a key, so trigger compaction is meaningful. So it's better to skip the heartbeat topic to do the compaction. ### Modification - Move `preCreateSubscriptionForCompactionIfNeeded` after `initialize`. - Add heartbeat topic not trigger compaction.
lhotari
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 5, 2022
…pache#13611) (cherry picked from commit 5835191)
15 tasks
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13479
Master Issue: #13479
Motivation
see #13479
Modifications
healthcheckinternal topic as SystemTopic.Verifying this change
Does this pull request potentially affect one of the following parts:
none.
Documentation
no-need-doc