[improve][broker] Heartbeat topic enable checkMessageExpire #20832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
|
The fix is good, Could you add a test? |
nodece
approved these changes
Jul 20, 2023
Test is done. @Technoboy- |
lifepuzzlefun
approved these changes
Jul 29, 2023
tisonkun
approved these changes
Aug 7, 2023
|
/pulsarbot rerun-failure-checks |
|
The pr had no activity for 30 days, mark with Stale label. |
Technoboy-
force-pushed
the
improve_heartbeat_topic_enable_message_expire
branch
from
03e289b to
12b5119
Compare
|
Actually in our pulsar environment, compaction is trigger, thats the reason why ledger not clean. With this pr, #14643. Heartbeat topic no longer trigger compaction. This problem can be fix. So close this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Running pulsar cluster for a long time, we found there are thousands of ledgers of heartbeat topic. The reason is heartbeat topic do not clean the expired message because it is systemTopic. The behaviour change since this pr #13611.
I think it is no need to keep heartbeat topic message permanently and we'd better clean the expired message and the ledger.
Modifications
modify checkMessageExpire()
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: