Skip to content

cleaned up *CommitViewEvent#3441

Closed
evindj wants to merge 164 commits intoapache:mainfrom
evindj:view_table_parity
Closed

cleaned up *CommitViewEvent#3441
evindj wants to merge 164 commits intoapache:mainfrom
evindj:view_table_parity

Conversation

@evindj
Copy link
Contributor

@evindj evindj commented Jan 14, 2026

This PR addresses issue #3418 after this PR recently did the same for tables.
Given that the current implementation of commitTransaction works only for table (from my reading, please correct if I am wrong), I concluded only removing events would be enough especially since *ReplaceView is already supported.

Tests:

Ran integration tests.

Checklist

  • 🛡️ Don't disclose security issues! (contact security@apache.org)
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

@evindj
Copy link
Contributor Author

evindj commented Jan 14, 2026

cc @snazy , @adnanhemani

@evindj
Copy link
Contributor Author

evindj commented Jan 23, 2026

@snazy or @adnanhemani please can one of you have a look when you have time?

Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evindj for tackling the issue!

The changes LGTM, but the PR needs to be rebased and the conflicts resolved.

CHANGELOG.md Outdated
- The EclipseLink Persistence implementation has been completely removed.
- The default request ID header name has changed from `Polaris-Request-Id` to `X-Request-ID`.
- The (Before/After)CommitTableEvent has been removed.
- The (Before/After)CommitViewEvent has been removed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to go into the "unreleased" part of CHANGELOG.

@dimas-b dimas-b requested a review from adutra January 26, 2026 16:53
renovate-bot and others added 22 commits January 26, 2026 11:24
To prevent duplicate version-bump PRs like apache#3299 and apache#3300
* Ensure release publish workflow can only run from last RC (apache#3290)
* Enable use of second release workflow for RC>0
* Patch 3rd workflow to support commits with multiple RC tags
* Force 4th workflow to only run from a release branch
* Update release guide to match new workflows
* Fix openapi-generator-cli version in build system

* Fix openapi-generator-cli version in build system
This is a safety net in case Properties are generated anywhere during the build.
Add error detection and validation to API calls in the quickstart
docker-compose setup with clear error messages for easier debugging.
MonkeyCanCode and others added 25 commits January 26, 2026 11:37
…e#3511)

* Add doc for couple new feature flags

* Add doc for couple new feature flags
* Fading anchor

* Fading anchor
The `site.yml` workflow is currently triggered in the following scenarios:
1. A push to the `main` branch, using the state of the site and the workflow as on `main`.
2. A push to a `release/*`branch, using the state of the site and the workflow as on that release branch.

Notice that workflows get the repo state (from the checkout actions) and the workflow state as its on that particular branch.
Put in other words: if we'd have a change to some old `release/1.0.x` branch, the web site would be updated as it is defined on that `release/1.0.x` branch, which is wrong and not the intended behavior.

This change updates the workflow triggers to only run for pushes to the `main` branch, plus PRs against the `main` branch and when called from another workflow.

This is part of apache#3516
The script `site/bin/checkout-releases.sh` is a convenience to get the `versioned-docs` branch locally. It is missing a `git pull` to get the latest state of that branch though, which can be confusing.
The Iceberg PR apache/iceberg#14991 bumps the https://github.com/RoaringBitmap/RoaringBitmap version, which is not published to Maven Central. We need to declare in the jitpack.io repository to prepare for the next Iceberg release.
…apache#3507)

Addresses the issues discussed on the dev mailing-list discussion https://lists.apache.org/thread/gkyw7m4fcbjbzhcrlrp4kcq5lr05r0m4, opting to use Guava as the easiest replacement here.
@evindj
Copy link
Contributor Author

evindj commented Jan 26, 2026

messed up the rebase flow will create a new PR

@evindj evindj closed this Jan 26, 2026
@github-project-automation github-project-automation bot moved this from PRs In Progress to Done in Basic Kanban Board Jan 26, 2026
@evindj evindj deleted the view_table_parity branch January 26, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.