removed references of BEFORE/AFTER_COMMIT_VIEW#3554
Conversation
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
| AFTER_REPLACE_VIEW, | ||
| BEFORE_COMMIT_VIEW, | ||
| AFTER_COMMIT_VIEW, | ||
| BEFORE_COMMIT_VIEW, // REMOVED FROM SOURCE CODE |
There was a problem hiding this comment.
I'm catching up here and saw this related conversation:
https://github.com/apache/polaris/pull/3195/changes#r2593440033
I'm not sure I agree with keeping these constants. Granted the ordinals will change if we remove them. But the feature is in beta status right now. It feels odd to see deprecated/unused constants in an API that is not even "official" yet.
@adnanhemani @dimas-b what do you think?
There was a problem hiding this comment.
I do not see any particular issue with changing ordinals. AFAIK, Polaris does not use java serialization for this enum and Jackson deals with names.
There was a problem hiding this comment.
If we are to remove the constants, will be ok doing in a follow up PR?cc @adutra I can take ownership of that issue as well.
There was a problem hiding this comment.
I think doing it in a separate PR makes sense, so the two other similar enum values can be removed as well.
There was a problem hiding this comment.
@evindj can you take care of the enum above in a separate PR?
There was a problem hiding this comment.
+1 for tackling this in a separate PR. Thanks @evindj !
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
* Replace custom token-bucket implementation with Guava's `RateLimiter` (apache#3507) Addresses the issues discussed on the dev mailing-list discussion https://lists.apache.org/thread/gkyw7m4fcbjbzhcrlrp4kcq5lr05r0m4, opting to use Guava as the easiest replacement here. * Move idempotency_records schema to v4 and add H2 support (apache#3386) * Move idempotency_records schema to v4 and add H2 support * address comments and fix test failures * fix format * add comment to resource_id * (nit): Getting started examples with mc/s5cmd to aws cli (apache#3526) * Switch mc/s3cmd to aws cli * Switch mc/s3cmd to aws cli * Add support for no KMS with s3-compatible backend (apache#3501) * chore(deps): update amazon/aws-cli docker tag to v2.33.7 (apache#3558) * Update doc for helm around rateLimiter (apache#3562) * Disable renoavte update for python version (apache#3560) * Fix the Keycloak getting-started example for 26.5+ (apache#3568) The example was failing because Keycloak 26.5 introduced stricter validation rules for session lifespan and timeout. * NoSQL: Add to runtime-service (apache#3396) * NoSQL: Add to runtime-service This change adds the NoSQL persistence to polaris-runtime-service. * chore(deps): update amazon/aws-cli docker tag to v2.33.8 (apache#3575) * Add spark sql integration test for Hudi (apache#3194) * Fix ozone getting started example (apache#3574) * Fix Ozone getting started example * Fix Ozone getting started example * Change AWS CLI image to weekly (apache#3578) * fix(deps): update dependency com.diffplug.spotless:spotless-plugin-gradle to v8.2.1 (apache#3576) * chore(deps): update registry.access.redhat.com/ubi9/openjdk-21-runtime docker tag to v1.24-2.1769108682 (apache#3588) * removed references of BEFORE/AFTER_COMMIT_VIEW (apache#3554) * nits - post-merge fixes * Last merged commit 2b0ca21 --------- Co-authored-by: Huaxin Gao <huaxin.gao11@gmail.com> Co-authored-by: Yong Zheng <yongzheng0809@gmail.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Alexandre Dutra <adutra@apache.org> Co-authored-by: Rahil C <32500120+rahil-c@users.noreply.github.com> Co-authored-by: Innocent Djiofack <djiofack007@gmail.com>
4 participants
This PR addresses issue #3418 after this PR recently did the same for tables.
Given that the current implementation of commitTransaction works only for table (from my reading, please correct if I am wrong), I concluded only removing events would be enough especially since *ReplaceView is already supported.
Tests:
Ran integration tests.
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)