Skip to content

Disable cloud storage tests that would use @TempDir#3095

Merged
dimas-b merged 1 commit intoapache:mainfrom
tmater:disable_cloud_tests
Nov 21, 2025
Merged

Disable cloud storage tests that would use @TempDir#3095
dimas-b merged 1 commit intoapache:mainfrom
tmater:disable_cloud_tests

Conversation

@tmater
Copy link
Contributor

@tmater tmater commented Nov 19, 2025

Summary

Disables 5 view catalog tests for cloud storage providers (S3, ADLS, GCS) that use @TempDir. The ViewCatalogTests base class uses Paths.get() with the temp directory, which doesn't support cloud storage paths.

Follow-up to #2871.

Background

These tests inherit from Iceberg's ViewCatalogTests, which passes a @TempDir path to Paths.get(). Since Paths.get() only accepts local filesystem paths, it cannot handle cloud storage URIs. For example, when @TempDir provides /tmp/junit123, Paths.get() converts it to a URI like file:///tmp/junit123. But for cloud storage base paths like s3://bucket/path, it would incorrectly create s3:/bucket/path (single slash) instead of the valid s3://bucket/path format.

These tests are disabled to prevent false positives - they would pass by testing against local filesystem instead of actually validating cloud storage behavior.

Changes

Base test classes - Added @Disabled overrides for 5 tests:

  • PolarisRestCatalogViewAdlsIntegrationTestBase.java
  • PolarisRestCatalogViewGcsIntegrationTestBase.java
  • PolarisRestCatalogViewS3IntegrationTestBase.java

Concrete test classes - Removed reflection workaround:

  • RestCatalogViewAdlsIT.java
  • RestCatalogViewGcsIT.java
  • RestCatalogViewS3IT.java

Testing

Run cloud tests: ./gradlew cloudTest

Future Work

Will follow up with changes to Iceberg's ViewCatalogTests to avoid using Paths.get() with @TempDir. Once that's done, these tests can be re-enabled.

@tmater
Disable cloud storage tests that would use @tempdir
578e6ff 
Disable tests from ViewCatalogTests for cloud storage integration tests
(S3, ADLS, GCS) that would otherwise use @tempdir. Since @tempdir internally
uses Paths.get, it cannot point to cloud storage paths. These tests remain
enabled for file-based integration tests.
@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Nov 19, 2025
@tmater tmater marked this pull request as ready for review November 19, 2025 19:02
dimas-b
dimas-b approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @tmater !

I think disabling these tests for now is a reasonable approach.

However, in the log run, should we rather fix the tests to allow any (configurable) storage URIs?

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Nov 19, 2025
@tmater
Copy link
Contributor Author

tmater commented Nov 19, 2025

Thank you for the quick review, @dimas-b and @snazy!

@dimas-b, I’ve already started experimenting with some changes. I don’t expect them to be too disruptive, but we’ll also need to bump our Iceberg version for that. I figured it’s better to disable these for now.

@dimas-b
Copy link
Contributor

dimas-b commented Nov 19, 2025

Yes, I'm sure an Iceberg change will be needed to make the test reusable in cloud environments.

@tmater tmater mentioned this pull request Nov 21, 2025
Merged
@dimas-b dimas-b merged commit 89eb4cc into apache:main Nov 21, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Nov 21, 2025
@tmater tmater mentioned this pull request Nov 27, 2025
Open
snazy added a commit to snazy/polaris that referenced this pull request Feb 11, 2026
@snazy @olsoloviov
@adutra @Subham-KRLX @pingtimeout @renovate-bot @MonkeyCanCode @XN137 @flyrain @sakshamratra0106 @dimas-b @tmater @gh-yzou
Dremio merge 2025 11 24 09 20 (apache#167)
32097e7 
* Docs: update Helm Chart page to show usage without cloning Polaris github repo (apache#2939)

* Docs: update Helm Chart page to show usage without cloning Polaris github repo

* Apply suggestions from code review

* Add separate flows in Helm Chart doc for installing released chart and images vs building from source

---------

Co-authored-by: Alexandre Dutra <adutra@apache.org>

* docs: improve getting started and README documentation (apache#2267)

* The outdated config snippets and health-checks are removed from the index

* The binary guide stays focused and concise

* Update changelog with missing 1.3.0 features (apache#3087)

* Update registry.access.redhat.com/ubi9/openjdk-21-runtime Docker tag to v1.23-6.1763034977 (apache#3092)

* Update docker.io/jaegertracing/all-in-one Docker tag to v1.75.0 (apache#3093)

* feat: Make generate_clients.py windows compatible (apache#3084)

* Make generate_clients.py windows compatible

* Updated CHANGELOG.md

* PRs: Remove markdown-links-check from required checks (apache#3102)

The "Check Markdown links" workflow is known to produce false failures, leading to apache#3097.

This change is intended to unblock PRs due to these false failures.

* Update dependency com.diffplug.spotless:spotless-plugin-gradle to v8.1.0 (apache#3083)

* Update dependency com.diffplug.spotless:spotless-plugin-gradle to v8.1.0

* spotlessApply

---------

Co-authored-by: Robert Stupp <snazy@snazy.de>

* chore(deps): update gradle to v9.2.1 (apache#3069)

* chore(deps): update gradle to v9.2.1

* Fix Grale wrapper SHA

---------

Co-authored-by: Robert Stupp <snazy@snazy.de>

* chore(deps): update mongo docker tag to v8.2.2 (apache#3100)

* chore(deps): update docker.io/mongo docker tag to v8.2.2 (apache#3099)

* Source-tarball - eliminate git-gzip risk (apache#3075)

Details in the `git archive` chapter in https://reproducible-builds.org/docs/archives/

* NoSQL: Allow `null` IndexKey (de)serialization (apache#3076)

This change adopts the implementation to the API specification.

* PRs: Re-add markdown-links-check step (apache#3103)

The step was disabled in apache#3102 to pass CI and enable merging.

* NoSQL: Add maintenance implementation (apache#3077)

* Inject DefaultFileIOFactory in tests (apache#3043)

* Inject DefaultFileIOFactory in tests

also simplify `TaskFileIOSupplier` usage in tests, which allows removal
of `TestFileIOFactory`.

* Update Quarkus Platform and Group to v3.29.4 (apache#3094)

* Site: Replace feather logo (apache#3101)

The ASF has a new logo, a leaf. There is sadly no free icon that matches the new logo, so replacing the feather-ASF with "The ASF" in the top-bar navigation.

* Update actions/checkout action to v6 (apache#3106)

* Core: resolveAll() must be called before reading resolution results (apache#3064)

* Site: Added GCS related Bucket Properties for vending credentials. (apache#3066)

* Publish/pom: don't include test-fixtures dependencies as runtime (apache#3085)

The list of dependencies in pom's includes the api/runtime elements of the test-fixtures, which is not what should be published, as it "pulls up" deps like junit, mockito and assertj as Maven runtime scope dependencies.
This change fixes this.

* Increase javadoc visibility in `persistence/nosql/persistence/cdi/weld` (apache#3110)

This is to fix javadoc error: `No public or protected classes found to document`

* Disable cloud storage tests that would use @tempdir (apache#3095)

Disable tests from ViewCatalogTests for cloud storage integration tests
(S3, ADLS, GCS) that would otherwise use @tempdir. Since @tempdir internally
uses Paths.get, it cannot point to cloud storage paths. These tests remain
enabled for file-based integration tests.

* Remove 'beta' label for Generic Table (apache#3096)

* remove beta label

* address comments for change log

---------

Co-authored-by: Pierre Laporte <pierre@pingtimeout.fr>

* Update dependency jupyterlab to v4.5.0 (apache#3074)

* chore: Fix md link check in GH action (apache#3128)

* Fix md link check in GH action

* Fix md link check in GH action

* Update dependency pre-commit to v4.5.0 (apache#3123)

* Update dependency software.amazon.awssdk:bom to v2.39.2 (apache#3127)

* NoSQL: authZ API, SPI, impl and store (apache#3078)

NoSQL base functionality for ACLs

* NoSQL: Quarkus distributed cache invalidation (apache#3105)

Adds support for distributed NoSQL cache invalidation leveraging Quarkus.

* NoSQL: adjustments / merge fixes

* Last merged commit e124348

---------

Co-authored-by: Oleg Soloviov <40199597+olsoloviov@users.noreply.github.com>
Co-authored-by: Alexandre Dutra <adutra@apache.org>
Co-authored-by: Subham <subham.sangwan@adypu.edu.in>
Co-authored-by: Pierre Laporte <pierre@pingtimeout.fr>
Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: Yong Zheng <yongzheng0809@gmail.com>
Co-authored-by: Christopher Lambert <xn137@gmx.de>
Co-authored-by: Yufei Gu <yufei@apache.org>
Co-authored-by: Saksham Ratra <sakshamratra.0106@gmail.com>
Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com>
Co-authored-by: Tamas Mate <50709850+tmater@users.noreply.github.com>
Co-authored-by: Yun Zou <yunzou.colostate@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snazy snazy snazy approved these changes

@dimas-b dimas-b dimas-b approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmater @dimas-b @snazy