Inject DefaultFileIOFactory in tests#3043
Merged
dimas-b merged 2 commits intoapache:mainfrom Nov 20, 2025
Merged
Conversation
XN137
force-pushed
the
inject-FileIOFactory-in-tests
branch
from
7dcaf65 to
b7771df
Compare
dimas-b
previously approved these changes
Nov 17, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
snazy
reviewed
Nov 17, 2025
...e/service/src/test/java/org/apache/polaris/service/task/BatchFileCleanupTaskHandlerTest.java
Outdated
Show resolved
Hide resolved
...ervice/src/test/java/org/apache/polaris/service/task/ManifestFileCleanupTaskHandlerTest.java
Outdated
Show resolved
Hide resolved
also simplify `TaskFileIOSupplier` usage in tests, which allows removal of `TestFileIOFactory`.
XN137
force-pushed
the
inject-FileIOFactory-in-tests
branch
from
b7771df to
236b18a
Compare
snazy
approved these changes
Nov 18, 2025
dimas-b
approved these changes
Nov 20, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Feb 11, 2026
* Docs: update Helm Chart page to show usage without cloning Polaris github repo (apache#2939) * Docs: update Helm Chart page to show usage without cloning Polaris github repo * Apply suggestions from code review * Add separate flows in Helm Chart doc for installing released chart and images vs building from source --------- Co-authored-by: Alexandre Dutra <adutra@apache.org> * docs: improve getting started and README documentation (apache#2267) * The outdated config snippets and health-checks are removed from the index * The binary guide stays focused and concise * Update changelog with missing 1.3.0 features (apache#3087) * Update registry.access.redhat.com/ubi9/openjdk-21-runtime Docker tag to v1.23-6.1763034977 (apache#3092) * Update docker.io/jaegertracing/all-in-one Docker tag to v1.75.0 (apache#3093) * feat: Make generate_clients.py windows compatible (apache#3084) * Make generate_clients.py windows compatible * Updated CHANGELOG.md * PRs: Remove markdown-links-check from required checks (apache#3102) The "Check Markdown links" workflow is known to produce false failures, leading to apache#3097. This change is intended to unblock PRs due to these false failures. * Update dependency com.diffplug.spotless:spotless-plugin-gradle to v8.1.0 (apache#3083) * Update dependency com.diffplug.spotless:spotless-plugin-gradle to v8.1.0 * spotlessApply --------- Co-authored-by: Robert Stupp <snazy@snazy.de> * chore(deps): update gradle to v9.2.1 (apache#3069) * chore(deps): update gradle to v9.2.1 * Fix Grale wrapper SHA --------- Co-authored-by: Robert Stupp <snazy@snazy.de> * chore(deps): update mongo docker tag to v8.2.2 (apache#3100) * chore(deps): update docker.io/mongo docker tag to v8.2.2 (apache#3099) * Source-tarball - eliminate git-gzip risk (apache#3075) Details in the `git archive` chapter in https://reproducible-builds.org/docs/archives/ * NoSQL: Allow `null` IndexKey (de)serialization (apache#3076) This change adopts the implementation to the API specification. * PRs: Re-add markdown-links-check step (apache#3103) The step was disabled in apache#3102 to pass CI and enable merging. * NoSQL: Add maintenance implementation (apache#3077) * Inject DefaultFileIOFactory in tests (apache#3043) * Inject DefaultFileIOFactory in tests also simplify `TaskFileIOSupplier` usage in tests, which allows removal of `TestFileIOFactory`. * Update Quarkus Platform and Group to v3.29.4 (apache#3094) * Site: Replace feather logo (apache#3101) The ASF has a new logo, a leaf. There is sadly no free icon that matches the new logo, so replacing the feather-ASF with "The ASF" in the top-bar navigation. * Update actions/checkout action to v6 (apache#3106) * Core: resolveAll() must be called before reading resolution results (apache#3064) * Site: Added GCS related Bucket Properties for vending credentials. (apache#3066) * Publish/pom: don't include test-fixtures dependencies as runtime (apache#3085) The list of dependencies in pom's includes the api/runtime elements of the test-fixtures, which is not what should be published, as it "pulls up" deps like junit, mockito and assertj as Maven runtime scope dependencies. This change fixes this. * Increase javadoc visibility in `persistence/nosql/persistence/cdi/weld` (apache#3110) This is to fix javadoc error: `No public or protected classes found to document` * Disable cloud storage tests that would use @tempdir (apache#3095) Disable tests from ViewCatalogTests for cloud storage integration tests (S3, ADLS, GCS) that would otherwise use @tempdir. Since @tempdir internally uses Paths.get, it cannot point to cloud storage paths. These tests remain enabled for file-based integration tests. * Remove 'beta' label for Generic Table (apache#3096) * remove beta label * address comments for change log --------- Co-authored-by: Pierre Laporte <pierre@pingtimeout.fr> * Update dependency jupyterlab to v4.5.0 (apache#3074) * chore: Fix md link check in GH action (apache#3128) * Fix md link check in GH action * Fix md link check in GH action * Update dependency pre-commit to v4.5.0 (apache#3123) * Update dependency software.amazon.awssdk:bom to v2.39.2 (apache#3127) * NoSQL: authZ API, SPI, impl and store (apache#3078) NoSQL base functionality for ACLs * NoSQL: Quarkus distributed cache invalidation (apache#3105) Adds support for distributed NoSQL cache invalidation leveraging Quarkus. * NoSQL: adjustments / merge fixes * Last merged commit e124348 --------- Co-authored-by: Oleg Soloviov <40199597+olsoloviov@users.noreply.github.com> Co-authored-by: Alexandre Dutra <adutra@apache.org> Co-authored-by: Subham <subham.sangwan@adypu.edu.in> Co-authored-by: Pierre Laporte <pierre@pingtimeout.fr> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Yong Zheng <yongzheng0809@gmail.com> Co-authored-by: Christopher Lambert <xn137@gmx.de> Co-authored-by: Yufei Gu <yufei@apache.org> Co-authored-by: Saksham Ratra <sakshamratra.0106@gmail.com> Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com> Co-authored-by: Tamas Mate <50709850+tmater@users.noreply.github.com> Co-authored-by: Yun Zou <yunzou.colostate@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also simplify
TaskFileIOSupplierusage in tests, which allows removalof
TestFileIOFactory.