HDDS-12852. Implement a sliding window counter utility #8498

ptlrs · 2025-05-21T18:09:23Z

What changes were proposed in this pull request?

Please describe your PR in detail:

This PR implements a generic timer-based sliding window class that can be used for checks with intermittent failures.
The window stores only the failed results to limit the in-memory data structures.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12852

How was this patch tested?

Added new unit tests
CI: https://github.com/ptlrs/ozone/actions/runs/16235740233

adoroszlai

Thanks @ptlrs for the patch.

I suggest removing the concept of failure from SlidingWindow, and let it simply track a limited number of event timestamps.

Rename members accordingly:

failureTolerance -> maxSize
failureTimestamps -> timestamps
isFailed() -> isEmpty() (inverting meaning)
removeExpiredFailures() -> removeExpired()
getFailureCount() -> size() (taken from follow-up PR)

Code tracking volume failures using SlidingWindow should add() only for failed check results, instead of letting the SlidingWindow decide based on an argument.

...iner-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/SlidingWindow.java

Tejaskriya

Thanks for working on this @ptlrs, Please find my comment below

...iner-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/SlidingWindow.java

…ng window.

…g-window

…class

ptlrs · 2025-07-13T03:25:24Z

Hi @adoroszlai @Tejaskriya, the comments have been addressed. Could you please review this PR again.

adoroszlai

Thanks @ptlrs for updating the patch. Implementation looks good, I think the test can be improved a bit.

...-service/src/test/java/org/apache/hadoop/ozone/container/common/utils/TestSlidingWindow.java

...iner-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/SlidingWindow.java

…r tests

ptlrs · 2025-07-13T08:16:29Z

Thanks for the review @adoroszlai. I have updated the tests.

adoroszlai

Thanks @ptlrs for updating the patch.

Tejaskriya

Thanks for the patch @ptlrs , LGTM

errose28

Thanks for working on this @ptlrs. I have some comments in addition to what has already been left.

...iner-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/SlidingWindow.java

...-service/src/test/java/org/apache/hadoop/ozone/container/common/utils/TestSlidingWindow.java

...iner-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/SlidingWindow.java

… package

… assertions

…ests

ptlrs · 2025-07-18T05:32:25Z

@errose28 the PR has been updated with the changes. The isFull method is now called isExceeded. We also now allow a window of size 0.

errose28

Only one comment on functionality left then I think this is ready to merge.

hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/SlidingWindow.java

hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/utils/TestSlidingWindow.java

…alization in SlidingWindow

errose28

Thanks for the updates @ptlrs. Next we can start using this to simplify the volume scanners' failure criteria. Should be good to merge once CI finishes.

ptlrs · 2025-07-21T22:54:39Z

Thanks for the extensive reviews @adoroszlai @errose28 @Tejaskriya.

Tejaskriya · 2025-07-22T04:04:31Z

Thanks for the patch @ptlrs and the reviews @adoroszlai @errose28

* master: (730 commits) HDDS-13083. Handle cases where block deletion generates tree file before scanner (apache#8565) HDDS-12982. Reduce log level for snapshot validation failure (apache#8851) HDDS-13396. Documentation: Improve the top-level overview page for new users. (apache#8753) HDDS-13176. containerIds table value format change to proto from string (apache#8589) HDDS-13449. Incorrect Interrupt Handling for DirectoryDeletingService and KeyDeletingService (apache#8817) HDDS-2453. Add Freon tests for S3 MPU Keys (apache#8803) HDDS-13237. Container data checksum should contain block IDs. (apache#8773) HDDS-13489. Fix SCMBlockdeleting unnecessary iteration in corner case. (apache#8847) HDDS-13464. Make ozone.snapshot.filtering.service.interval reconfigurable (apache#8825) HDDS-13473. Amend validation for OZONE_OM_SNAPSHOT_DB_MAX_OPEN_FILES (apache#8829) HDDS-13435. Add an OzoneManagerAuthorizer interface (apache#8840) HDDS-8565. Recon memory leak in NSSummary (apache#8823). HDDS-12852. Implement a sliding window counter utility (apache#8498) HDDS-12000. Add unit test for RatisContainerSafeModeRule and ECContainerSafeModeRule (apache#8801) HDDS-13092. Container scanner should trigger volume scan when marking a container unhealthy (apache#8603) HDDS-13070. OM Follower changes to create and place sst files from hardlink file. (apache#8761) HDDS-13482. Mark testWriteStateMachineDataIdempotencyWithClosedContainer as flaky HDDS-13481. Fix success latency metric in SCM panels of deletion grafana dashboard (apache#8835) HDDS-13468. Update default value of ozone.scm.ha.dbtransactionbuffer.flush.interval. (apache#8834) HDDS-13410. Control block deletion for each DN from SCM. (apache#8767) ... hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerReplicaInfo.java hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/container/ReconcileSubcommand.java hadoop-ozone/cli-admin/src/test/java/org/apache/hadoop/hdds/scm/cli/container/TestReconcileSubcommand.java

HDDS-12852. Implement a sliding window based failure counter utility

2d6175a

errose28 added the scanners Changes related to datanode container and volume scanners label May 22, 2025

jojochuang requested a review from errose28 June 2, 2025 16:58

HDDS-12852. Update tests

b5d51ff

ptlrs mentioned this pull request Jun 2, 2025

HDDS-13108. Migrate failed volume checks to one sliding window #8543

Closed

errose28 requested a review from Tejaskriya June 10, 2025 21:19

adoroszlai reviewed Jun 12, 2025

View reviewed changes

Tejaskriya reviewed Jun 16, 2025

View reviewed changes

...iner-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/SlidingWindow.java Outdated Show resolved Hide resolved

ptlrs added 6 commits July 11, 2025 09:35

HDDS-12852. refactor from a failure sliding window to a generic slidi…

429052f

…ng window.

HDDS-12852. Remove unused methods from SlidingWindow class

b0d2f68

Merge remote-tracking branch 'upstream/master' into HDDS-12852-slidin…

94665ba

…g-window

HDDS-12852. Remove unused expiryDuration field from SlidingWindow class

863b364

HDDS-12852. Add expiryDuration field initialization in SlidingWindow …

0944203

…class

HDDS-12852. Remove unused expiryDuration field from SlidingWindow class

c9efc73

ptlrs requested review from Tejaskriya and adoroszlai July 13, 2025 03:24

adoroszlai reviewed Jul 13, 2025

View reviewed changes

HDDS-12852. Add support for custom Clock in SlidingWindow and refacto…

36a32ed

…r tests

ptlrs requested a review from adoroszlai July 13, 2025 08:16

adoroszlai marked this pull request as ready for review July 13, 2025 09:31

adoroszlai approved these changes Jul 13, 2025

View reviewed changes

adoroszlai changed the title ~~HDDS-12852. Implement a sliding window based failure counter utility~~ HDDS-12852. Implement a sliding window counter utility Jul 13, 2025

Tejaskriya approved these changes Jul 14, 2025

View reviewed changes

errose28 requested changes Jul 16, 2025

View reviewed changes

ptlrs added 3 commits July 16, 2025 19:49

HDDS-12852. Refactor SlidingWindow class and relocate to common utils…

08a522c

… package

HDDS-12852. Add getNumEvents method to SlidingWindow and improve test…

6fc39bd

… assertions

HDDS-12852. Rename isFull to isExceeded in SlidingWindow and update t…

f05613a

…ests

ptlrs requested a review from errose28 July 18, 2025 05:30

errose28 reviewed Jul 18, 2025

View reviewed changes

HDDS-12852. Add @VisibleForTesting annotation and refactor test initi…

394a482

…alization in SlidingWindow

ptlrs requested a review from errose28 July 18, 2025 21:11

HDDS-12852. Add getNumEventsInWindow method to SlidingWindow

823aa5f

errose28 approved these changes Jul 21, 2025

View reviewed changes

Tejaskriya merged commit e50365a into apache:master Jul 22, 2025
42 checks passed

ptlrs mentioned this pull request Jul 22, 2025

HDDS-13108. Migrate failed volume checks to one sliding window #8843

Closed

jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Jul 31, 2025

HDDS-12852. Implement a sliding window counter utility (apache#8498)

a518521

HDDS-12852. Implement a sliding window counter utility #8498

HDDS-12852. Implement a sliding window counter utility #8498

Uh oh!

Conversation

ptlrs commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

What is the link to the Apache JIRA

How was this patch tested?

Uh oh!

adoroszlai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tejaskriya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ptlrs commented Jul 13, 2025

Uh oh!

adoroszlai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ptlrs commented Jul 13, 2025

Uh oh!

adoroszlai left a comment

Choose a reason for hiding this comment

Uh oh!

Tejaskriya left a comment

Choose a reason for hiding this comment

Uh oh!

errose28 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ptlrs commented Jul 18, 2025

Uh oh!

errose28 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

errose28 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ptlrs commented Jul 21, 2025

Uh oh!

Uh oh!

Tejaskriya commented Jul 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ptlrs commented May 21, 2025 •

edited

Loading

errose28 left a comment •

edited

Loading