HDDS-13108. Migrate failed volume checks to one sliding window #8843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… scanner failures
…e-failed-volume-checks-to-one-sliding-window
…g window mechanism
Contributor
Author
|
Hi @errose28 @Tejaskriya @adoroszlai can you please review this PR? |
errose28
added
the
scanners
Tejaskriya
reviewed
Jul 29, 2025
Contributor
Tejaskriya
left a comment
Tejaskriya
left a comment
There was a problem hiding this comment.
Thanks for working on this @ptlrs , please find a suggestion below
...ner-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/StorageVolume.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the review @Tejaskriya. I have added the configuration. |
Tejaskriya
reviewed
Aug 4, 2025
Contributor
Tejaskriya
left a comment
Tejaskriya
left a comment
There was a problem hiding this comment.
Looks good to me, @errose28 could you please take a look?
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
|
Thank you for your contribution. This PR is being closed due to inactivity. If needed, feel free to reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your PR in detail:
This PR uses the new sliding window implementation.
It migrates all existing checks to detect a failed volume to use the new time-based sliding window utility.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13108
How was this patch tested?
CI:https://github.com/ptlrs/ozone/actions/runs/16436635030