HDDS-7794. [snapshot] SnapshotDiff should throw better error messages for exception handling #5007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for exception handling
prashantpogde
approved these changes
Jun 30, 2023
Contributor
prashantpogde
left a comment
prashantpogde
left a comment
There was a problem hiding this comment.
LGTM. thanks @swamirishi for this PR.
Contributor
|
@swamirishi Please fix the PR title. It should use |
swamirishi
changed the title
hemantk-12
reviewed
Jun 30, 2023
| } | ||
| if (snapshotInfo == null) { | ||
| throw new OMException(KEY_NOT_FOUND); | ||
| throw new OMException("Snapshot '" + snapshotKey + "' is not found.", |
Contributor
There was a problem hiding this comment.
nit: Should it be snapshotKey or snapshotName? I think snapshotName would be better.
Contributor
There was a problem hiding this comment.
@hemantk-12 In this case it only has dbKey (e.g. result of SnapshotInfo.getTableKey(volumeName, bucketName, snapshotName))
Contributor
There was a problem hiding this comment.
You are right. But I'm just thinking from client perspective snapshotName would be better which can be extracted from the snapshotKey I guess. At the same time it is not a big deal to return snapshotKey in exception message.
vtutrinov
pushed a commit
to Cyrill/ozone
that referenced
this pull request
Jul 3, 2023
… for exception handling (apache#5007)
vtutrinov
pushed a commit
to Cyrill/ozone
that referenced
this pull request
Jul 3, 2023
… for exception handling (apache#5007)
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jul 10, 2023
* master: (36 commits) HDDS-8990. Intermittent timeout waiting on datanode4 9856 to become available (apache#5039) Revert "HDDS-7750. Incorrect WRITE ACL check. (apache#4992)" HDDS-7750. Incorrect WRITE ACL check. (apache#4992) HDDS-8985. Intermittent timeout exiting safe mode in HA secure tests (apache#5033) HDDS-8593. Add RootCARotationPoller to CertClient (apache#5030) HDDS-7645. Kubernetes check should fail fast if cluster cannot start (apache#5028) HDDS-8981. TestRootedOzoneFileSystem runs out of disk space (apache#5029) HDDS-8592. Fetch and save all root certificates during service's certificate rotation. (apache#5025) HDDS-8981. Disable TestRootedOzoneFileSystem#testSafeMode HDDS-8591. Create scheduler to check for new root ca certificates (apache#4961) HDDS-8979. error validating kustomization.yaml (apache#5024) HDDS-8973. Ozone SCM HA should not allocates duplicate IDs when transferring leadership (apache#5018) HDDS-8970. Snapshot Diff should return path relative to bucket root (apache#5015) HDDS-8975. Clarify SCM HA auto-bootstrap doc (apache#5021) HDDS-8689. Rotate Root CA and Sub CA in SCM. (apache#4943) HDDS-8436. Support setSafeMode(), isFileClosed() FileSystem API (apache#4825) HDDS-8880. Intermittent fork timeout in TestOMRatisSnapshots (apache#5022) HDDS-8962. Ensure docker env is stopped (apache#5011) HDDS-7794. [snapshot] SnapshotDiff should throw better error messages for exception handling (apache#5007) HDDS-7922. [FSO] S3G folder support fso layout filestatus s3A compatibility (apache#4448) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add error message in case snapshot info not found.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7794
How was this patch tested?
Existing Unit test