HDDS-7750. Incorrect WRITE ACL check #4992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xushaohong
reviewed
Jun 29, 2023
| when(ozoneManager.getMetadataManager()).thenReturn(omMetadataManager); | ||
| auditLogger = Mockito.mock(AuditLogger.class); | ||
| OmMetadataReader omMetadataReader = Mockito.mock(OmMetadataReader.class); | ||
| when(ozoneManager.getOmMetadataReader()).thenReturn(omMetadataReader); |
Contributor
There was a problem hiding this comment.
This line is duplicated with line 85. Need to verify if the mock is necessary.
when(ozoneManager.getMetadataManager()).thenReturn(omMetadataManager);
Contributor
There was a problem hiding this comment.
They seem to be different: getMetadataManager vs. getOmMetadataReader.
sadanand48
reviewed
Jun 30, 2023
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
Thanks @aryangupta1998 for the patch, change looks good to me. The exact issue described in the jira seems not to be an issue.
adoroszlai
added a commit
that referenced
this pull request
Jul 10, 2023
Contributor
|
@aryangupta1998 @sadanand48 I have reverted this from #4567 changed - public OmMetadataReader getOmMetadataReader() {
- return omMetadataReader;
+ public ReferenceCounted<
+ IOmMetadataReader, SnapshotCache> getOmMetadataReader() {
+ return rcOmMetadataReader; |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jul 10, 2023
* master: (36 commits) HDDS-8990. Intermittent timeout waiting on datanode4 9856 to become available (apache#5039) Revert "HDDS-7750. Incorrect WRITE ACL check. (apache#4992)" HDDS-7750. Incorrect WRITE ACL check. (apache#4992) HDDS-8985. Intermittent timeout exiting safe mode in HA secure tests (apache#5033) HDDS-8593. Add RootCARotationPoller to CertClient (apache#5030) HDDS-7645. Kubernetes check should fail fast if cluster cannot start (apache#5028) HDDS-8981. TestRootedOzoneFileSystem runs out of disk space (apache#5029) HDDS-8592. Fetch and save all root certificates during service's certificate rotation. (apache#5025) HDDS-8981. Disable TestRootedOzoneFileSystem#testSafeMode HDDS-8591. Create scheduler to check for new root ca certificates (apache#4961) HDDS-8979. error validating kustomization.yaml (apache#5024) HDDS-8973. Ozone SCM HA should not allocates duplicate IDs when transferring leadership (apache#5018) HDDS-8970. Snapshot Diff should return path relative to bucket root (apache#5015) HDDS-8975. Clarify SCM HA auto-bootstrap doc (apache#5021) HDDS-8689. Rotate Root CA and Sub CA in SCM. (apache#4943) HDDS-8436. Support setSafeMode(), isFileClosed() FileSystem API (apache#4825) HDDS-8880. Intermittent fork timeout in TestOMRatisSnapshots (apache#5022) HDDS-8962. Ensure docker env is stopped (apache#5011) HDDS-7794. [snapshot] SnapshotDiff should throw better error messages for exception handling (apache#5007) HDDS-7922. [FSO] S3G folder support fso layout filestatus s3A compatibility (apache#4448) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changing checkKeyAcls() to checkKeyAclsInOpenKeyTable() in S3MultipartUploadCommitPartRequest as for Acl type "WRITE", the key can only be found in OpenKeyTable.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7750
How was this patch tested?
Tested Manually