Skip to content

HDDS-7794. [snapshot] SnapshotDiff should throw better error messages for exception handling #5007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prashantpogde merged 2 commits into from
Jun 30, 2023
Merged

HDDS-7794. [snapshot] SnapshotDiff should throw better error messages for exception handling #5007

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68e6e9f
HDDS-7794: [snapshot] SnapshotDiff should throw better error messages…
swamirishi Jun 30, 2023
f6baab8
HDDS-7794: Fix checkstyle
swamirishi Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ public static SnapshotInfo getSnapshotInfo(final OzoneManager ozoneManager,
throw e;
}
if (snapshotInfo == null) {
throw new OMException(KEY_NOT_FOUND);
throw new OMException("Snapshot '" + snapshotKey + "' is not found.",
Copy link
Contributor

@hemantk-12 hemantk-12 Jun 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should it be snapshotKey or snapshotName? I think snapshotName would be better.

Copy link
Contributor

@smengcl smengcl Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hemantk-12 In this case it only has dbKey (e.g. result of SnapshotInfo.getTableKey(volumeName, bucketName, snapshotName))

Copy link
Contributor

@hemantk-12 hemantk-12 Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. But I'm just thinking from client perspective snapshotName would be better which can be extracted from the snapshotKey I guess. At the same time it is not a big deal to return snapshotKey in exception message.

KEY_NOT_FOUND);
}
return snapshotInfo;
}
Expand Down