HDDS-8220. [Ozone-Streaming] Trigger volume check on IOException in StreamDataChannelBase #4428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@hemantk-12 can you please take a look? |
hemantk-12
approved these changes
Mar 20, 2023
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
Overall looks good to me.
Left some minor comments.
| return request; | ||
| } | ||
|
|
||
| private void volumeOnFailure() { |
Contributor
There was a problem hiding this comment.
nit: I don't think it is ideal to create function for one liner.
| super.close(); | ||
| try { | ||
| putBlockRequest.set(closeBuffers(buffers, super::writeFileChannel)); | ||
| super.close(); |
Contributor
There was a problem hiding this comment.
Should super.close() be out of the try-catch?
szetszwo
reviewed
Mar 21, 2023
Comment on lines
290
to
291
| private void volumeOnFailure() { | ||
| onFailure(getContainerData().getVolume()); |
Contributor
There was a problem hiding this comment.
@guohao-rosicky , thanks for working on this!
Let's move this method up and rename it to checkVolume.
+++ b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/StreamDataChannelBase.java
@@ -22,6 +22,7 @@
import org.apache.hadoop.hdds.scm.container.common.helpers.StorageContainerException;
import org.apache.hadoop.ozone.container.common.helpers.ContainerMetrics;
import org.apache.hadoop.ozone.container.common.impl.ContainerData;
+import org.apache.hadoop.ozone.container.common.utils.StorageVolumeUtil;
import org.apache.ratis.statemachine.StateMachine;
import java.io.File;
@@ -64,6 +65,10 @@ private FileChannel getChannel() {
return randomAccessFile.getChannel();
}
+ void checkVolume() {
+ StorageVolumeUtil.onFailure(containerData.getVolume());
+ }
+
@Override
public final void force(boolean metadata) throws IOException {
getChannel().force(metadata);
szetszwo
approved these changes
Mar 21, 2023
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
adoroszlai
changed the title
Contributor
|
Thanks @guohao-rosicky for the patch, @hemantk-12, @szetszwo for the review. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Mar 23, 2023
* master: (43 commits) HDDS-8148. Improve log for Pipeline creation failure (apache#4385) HDDS-7853. Add support for RemoveSCM in SCMRatisServer. (apache#4358) HDDS-8042. Display certificate issuer in cert list command. (apache#4429) HDDS-8189. [Snapshot] renamedKeyTable should only track keys in buckets that has at least one active snapshot. (apache#4436) HDDS-8154. Perf: Reuse Mac instances in S3 token validation (apache#4433) HDDS-8245. Info log for keyDeletingService when nonzero number of keys are deleted. (apache#4451) HDDS-8233. ReplicationManager: Throttle delete container commands from over-replication handlers (apache#4447) HDDS-8220. [Ozone-Streaming] Trigger volume check on IOException in StreamDataChannelBase (apache#4428) HDDS-8173. Fix to remove enrties from RocksDB after container gets deleted. (apache#4445) HDDS-7975. Rebalance acceptance tests (apache#4437) HDDS-8152. Reduce S3 acceptance test setup time (apache#4393) HDDS-8172. ECUnderReplicationHandler should consider commands already sent when processing the container (apache#4435) HDDS-7883. [Snapshot] Accommodate FSO, key renames and implement OMSnapshotPurgeRequest for SnapshotDeletingService (apache#4407) HDDS-8168. Make deadlines inside MoveManager for move commands configurable (apache#4415) HDDS-7918. EC: ECBlockReconstructedStripeInputStream should check for spare replicas before failing an index (apache#4441) HDDS-8222. EndpointBase#getBucket should handle BUCKET_NOT_FOUND (apache#4431) HDDS-8068. Fix Exception: JMXJsonServlet, getting attribute RatisRoles of Hadoop:service=OzoneManager. (apache#4352) HDDS-8139. Datanodes should not drop block delete transactions based on transaction ID (apache#4384) HDDS-8216. EC: OzoneClientConfig is overwritten in ECKeyOutputStream (apache#4425) HDDS-8054. Fix NPE in metrics for failed volume (apache#4340) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
KeyValueStreamDataChannel add write data exception handling
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8220