Skip to content

Conversation

@guohao-rosicky
Copy link
Contributor

What changes were proposed in this pull request?

EndpointBase#getBucket Exception capture content error

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8222

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guohao-rosicky for spotting the bug. Please add an assertion in existing test to verify result code:

@Test
public void testGetBucketFailure() throws Exception {
long oriMetric = metrics.getGetBucketFailure();
try {
// Searching for a bucket that does not exist
bucketEndpoint.get("newBucket", null,
null, null, 1000, null,
null, "random", null,
null, null);
fail();
} catch (OS3Exception e) {
}
long curMetric = metrics.getGetBucketFailure();
assertEquals(1L, curMetric - oriMetric);
}

@adoroszlai
Copy link
Contributor

Thanks @guohao-rosicky for adding the test. It turns out that the getBucket(OzoneVolume, String) method being fixed is not used by the test, or any other code for that matter. All callers use the other one, getBucket(String).

Anyway, the fix is fine and the test addition is welcome.

@adoroszlai adoroszlai changed the title HDDS-8222. EndpointBase#getBucket Exception capture content error HDDS-8222. EndpointBase#getBucket should handle BUCKET_NOT_FOUND Mar 21, 2023
@adoroszlai adoroszlai merged commit d088838 into apache:master Mar 21, 2023
errose28 added a commit to errose28/ozone that referenced this pull request Mar 23, 2023
* master: (43 commits)
  HDDS-8148. Improve log for Pipeline creation failure (apache#4385)
  HDDS-7853. Add support for RemoveSCM in SCMRatisServer. (apache#4358)
  HDDS-8042. Display certificate issuer in cert list command. (apache#4429)
  HDDS-8189. [Snapshot] renamedKeyTable should only track keys in buckets that has at least one active snapshot. (apache#4436)
  HDDS-8154. Perf: Reuse Mac instances in S3 token validation (apache#4433)
  HDDS-8245. Info log for keyDeletingService when nonzero number of keys are deleted. (apache#4451)
  HDDS-8233. ReplicationManager: Throttle delete container commands from over-replication handlers (apache#4447)
  HDDS-8220. [Ozone-Streaming] Trigger volume check on IOException in StreamDataChannelBase (apache#4428)
  HDDS-8173. Fix to remove enrties from RocksDB after container gets deleted. (apache#4445)
  HDDS-7975. Rebalance acceptance tests (apache#4437)
  HDDS-8152. Reduce S3 acceptance test setup time (apache#4393)
  HDDS-8172. ECUnderReplicationHandler should consider commands already sent when processing the container (apache#4435)
  HDDS-7883. [Snapshot] Accommodate FSO, key renames and implement OMSnapshotPurgeRequest for SnapshotDeletingService (apache#4407)
  HDDS-8168. Make deadlines inside MoveManager for move commands configurable (apache#4415)
  HDDS-7918. EC: ECBlockReconstructedStripeInputStream should check for spare replicas before failing an index (apache#4441)
  HDDS-8222. EndpointBase#getBucket should handle BUCKET_NOT_FOUND (apache#4431)
  HDDS-8068. Fix Exception: JMXJsonServlet, getting attribute RatisRoles of Hadoop:service=OzoneManager. (apache#4352)
  HDDS-8139. Datanodes should not drop block delete transactions based on transaction ID (apache#4384)
  HDDS-8216. EC: OzoneClientConfig is overwritten in ECKeyOutputStream (apache#4425)
  HDDS-8054. Fix NPE in metrics for failed volume (apache#4340)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants