Skip to content

HDDS-8220. [Ozone-Streaming] Trigger volume check on IOException in StreamDataChannelBase #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 4 commits into from
Mar 22, 2023
Merged

HDDS-8220. [Ozone-Streaming] Trigger volume check on IOException in StreamDataChannelBase #4428

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2363be
HDDS-8220. [Ozone-Streaming] KeyValueStreamDataChannel add write data…
guohao-rosicky Mar 20, 2023
8a7b5e9
trigger new CI
guohao-rosicky Mar 20, 2023
b043546
rename method
guohao-rosicky Mar 21, 2023
a9824aa
unused code
guohao-rosicky Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions .../src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/StreamDataChannelBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
import java.nio.ByteBuffer;
import java.nio.channels.FileChannel;

import static org.apache.hadoop.ozone.container.common.utils.StorageVolumeUtil.onFailure;

/**
* For write state machine data.
*/
Expand Down Expand Up @@ -64,9 +66,18 @@ private FileChannel getChannel() {
return randomAccessFile.getChannel();
}

protected void checkVolume() {
onFailure(containerData.getVolume());
}

@Override
public final void force(boolean metadata) throws IOException {
getChannel().force(metadata);
try {
getChannel().force(metadata);
} catch (IOException e) {
checkVolume();
throw e;
}
}

@Override
Expand All @@ -76,14 +87,24 @@ public final boolean isOpen() {

@Override
public void close() throws IOException {
randomAccessFile.close();
try {
randomAccessFile.close();
} catch (IOException e) {
checkVolume();
throw e;
}
}

final int writeFileChannel(ByteBuffer src) throws IOException {
final int writeBytes = getChannel().write(src);
metrics.incContainerBytesStats(getType(), writeBytes);
containerData.updateWriteStats(writeBytes, false);
return writeBytes;
try {
final int writeBytes = getChannel().write(src);
metrics.incContainerBytesStats(getType(), writeBytes);
containerData.updateWriteStats(writeBytes, false);
return writeBytes;
} catch (IOException e) {
checkVolume();
throw e;
}
}

@Override
Expand Down